volume api attributes should be consistent

Bug #943053 reported by Brian Waldon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Undecided
Brian Waldon
python-novaclient
Fix Released
High
Brian Waldon

Bug Description

The volumes api requests for creating volumes/snapshots accept attributes using underscores, but all responses format attributes as lower camel case. We should standardize on the latter.

Brian Waldon (bcwaldon)
Changed in nova:
milestone: essex-4 → none
Revision history for this message
Vish Ishaya (vishvananda) wrote :

This is actually a nasty usability issue and makes the api look unprofessional.

Create Volume Request: JSON

{
    "volume": {
        "display_name": "vol-001",
        "display_description": "Another volume.",
        "size": 30,
        "volume_type": "289da7f8-6440-407c-9fb4-7db01ec49164",
        "metadata": {"contents": "junk"},
        "availability_zone": "us-east1"
     }
}

Create Volume Response: JSON
{
    "volume": {
        "id": "521752a6-acf6-4b2d-bc7a-119f9148cd8c",
        "displayName": "vol-001",
        "displayDescription": "Another volume.",
        "size": 30,
        "volumeType": "289da7f8-6440-407c-9fb4-7db01ec49164",
        "metadata": {"contents": "junk"},
        "availabilityZone": "us-east1",
        "snapshotId": null,
        "attachments": [],
        "createdAt": "2012-02-14T20:53:07Z"
     }
}

It would be great if we could switch it but still support the old syntax for anyone who happens to be using it. But we should just publish the new syntax in the api docs. Supporting the old syntax will allow us to get through the merge gate as well.

Changed in nova:
importance: Medium → High
tags: added: essex-rc-potiential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5696

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/5714

Brian Waldon (bcwaldon)
Changed in openstack-manuals:
status: New → In Progress
assignee: nobody → Brian Waldon (bcwaldon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5737

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/5737
Committed: http://github.com/openstack/python-novaclient/commit/e7d35bf5c5ca6c80f4b86d55c8e760f9e87ffda2
Submitter: Jenkins
Branch: master

commit e7d35bf5c5ca6c80f4b86d55c8e760f9e87ffda2
Author: Brian Waldon <email address hidden>
Date: Fri Mar 23 09:19:29 2012 -0700

    Handle server_id and serverId in volume list

    * This is a temporary patch to get past the devstack gate
    * Helps fix bug 943053

    Change-Id: Id40f0c9d7b603029b1b6de6742fe7bff2482fe05

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/5714
Committed: http://github.com/openstack/nova/commit/58bcbc1151c7c509054bcfdfd0e4af7b62f71e9e
Submitter: Jenkins
Branch: master

commit 58bcbc1151c7c509054bcfdfd0e4af7b62f71e9e
Author: Brian Waldon <email address hidden>
Date: Thu Mar 22 14:39:52 2012 -0700

    Volumes API now uses underscores for attrs

    * Fixes bug 943053

    Change-Id: I7066e963b4377a4a1f8a3c259e6273e6a0ca073f

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/5695
Committed: http://github.com/openstack/openstack-manuals/commit/082797bbff6eec84e5099147ba5cedfb456a4252
Submitter: Jenkins
Branch: master

commit 082797bbff6eec84e5099147ba5cedfb456a4252
Author: Brian Waldon <email address hidden>
Date: Thu Mar 22 14:52:48 2012 -0700

    Volumes API uses underscores for attribute formats

    * Fixes bug 943053

    Change-Id: I1dc23b3b910ec2871672a79b9665eb9c517dd4b6

Changed in openstack-manuals:
status: In Progress → Fix Committed
Brian Waldon (bcwaldon)
Changed in nova:
milestone: none → essex-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/5830

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/5877

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (milestone-proposed)

Reviewed: https://review.openstack.org/5877
Committed: http://github.com/openstack/python-novaclient/commit/dcd906554dbffc849c2e494a6fc8d045ddd70eff
Submitter: Jenkins
Branch: milestone-proposed

commit dcd906554dbffc849c2e494a6fc8d045ddd70eff
Author: Brian Waldon <email address hidden>
Date: Fri Mar 23 09:19:29 2012 -0700

    Handle server_id and serverId in volume list

    * This is a temporary patch to get past the devstack gate
    * Helps fix bug 943053

    Change-Id: Id40f0c9d7b603029b1b6de6742fe7bff2482fe05

Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote :

(More coming up in RC2)

Changed in nova:
status: Fix Released → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (milestone-proposed)

Reviewed: https://review.openstack.org/5830
Committed: http://github.com/openstack/nova/commit/fb370c3793939e38bb8456dfe963c1ea0f745fec
Submitter: Jenkins
Branch: milestone-proposed

commit fb370c3793939e38bb8456dfe963c1ea0f745fec
Author: Brian Waldon <email address hidden>
Date: Thu Mar 22 14:39:52 2012 -0700

    Volumes API now uses underscores for attrs

    * Fixes bug 943053

    Change-Id: I7066e963b4377a4a1f8a3c259e6273e6a0ca073f

Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-rc2 → 2012.1
Anne Gentle (annegentle)
Changed in openstack-manuals:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
affects: nova → python-novaclient
Changed in python-novaclient:
milestone: 2012.1 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.