race condition when putting host in maintenance causes VM's state to be SHUTOFF
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
High
|
Armando Migliaccio | ||
Bug Description
putting a host in maintenance mode means moving all the VMs from the host to another host (effectively this is a live migration that requires the VM's host to change from the source host to the destination host).
Because of the potential concurrent execution of compute/
Looking at the implementation of _sync_power_states this problem can be solved by ensuring that the VM's host field is updated prior to the actual VM migration, and by reverting it to the old value if something goes wrong.
Current code in virt/xenapi/host.py was updating the VM's host field after the VM was migrated (to save one DB call in case of failures); clearly this does cause the race condition and need to be fixed.
| Changed in nova: | |
| status: | New → Confirmed |
| assignee: | nobody → Armando Migliaccio (armando-migliaccio) |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to nova (master) | #1 |
| Changed in nova: | |
| status: | Confirmed → In Progress |
| Changed in nova: | |
| milestone: | none → essex-rc1 |
| importance: | Undecided → High |
| status: | In Progress → Triaged |
| Changed in nova: | |
| status: | Triaged → In Progress |
| tags: | removed: xenserver |
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (master) | #2 |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| status: | Fix Committed → Fix Released |
| Changed in nova: | |
| milestone: | essex-rc1 → 2012.1 |
Fix proposed to branch: master
Review: https:/