Prevent bad images from corrupting SR

Bug #949477 reported by Rick Harris
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Rick Harris

Bug Description

A bad image for purposes of this bug is an image that contains a VHD that points to a parent that isn't present in the image.

If we copy this bad VHD into the SR, this will corrupt the SR preventing other VHDs from coalescing causing a cascading effect as even more "bad" images are created.

The solution is to detect this invalid parent relationship and abort the rebuild process.

Changed in nova:
assignee: nobody → Rick Harris (rconradharris)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5057

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/5057
Committed: http://github.com/openstack/nova/commit/1da6a00a3b351e035998345e92c44a94b502d0f8
Submitter: Jenkins
Branch: master

commit 1da6a00a3b351e035998345e92c44a94b502d0f8
Author: Rick Harris <email address hidden>
Date: Thu Mar 8 01:26:04 2012 +0000

    Validate VDI chain before moving into SR.

    Fixes bug 949477

    Change-Id: Ia3f283d82f189e680c5c8dd4fcf71bf5fe5f9889

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5174

Changed in nova:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/5174
Committed: http://github.com/openstack/nova/commit/e6cf7fc7f48a80e87f24e4f7b6f57d273f9d2a27
Submitter: Jenkins
Branch: master

commit e6cf7fc7f48a80e87f24e4f7b6f57d273f9d2a27
Author: Rick Harris <email address hidden>
Date: Fri Mar 9 23:26:25 2012 +0000

    Add VDI chain cleanup script.

    References bug 949477

    Change-Id: I819d4ed56675a4ef4e46adca2978b433386e128d

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.