Response bodies should never contain a backtrace

Bug #955411 reported by Dolph Mathews
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Dolph Mathews

Bug Description

All errors, expected or otherwise, should be wrapped in a keystone.exception.Error.

The client interprets this class of errors correctly, printing the error message and status code in a user friendly format -- keystone needs to take advantage of that to improve the user experience.

This implies suppressing unexpected backtraces from the API but they must still be properly logged (error level).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5358

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/5358
Committed: http://github.com/openstack/keystone/commit/009d661a7e06ad72ab39b93433839bf567755ece
Submitter: Jenkins
Branch: master

commit 009d661a7e06ad72ab39b93433839bf567755ece
Author: Dolph Mathews <email address hidden>
Date: Wed Mar 14 15:06:16 2012 -0500

    Wrapped unexpected exceptions (bug 955411)

    - Replaced all webob.exc's (outside of middleware) with
      keystone.exception's
    - Raised 409 Conflict when creating/updating existing
      user/tenant ID/names (bug 955464)
    - Raised 501 Not Implemented for user-role-add w/o tenant_id
      (bug 955548)

    Change-Id: I9f16cac502c20dd35a6b8da778e85bf3d9cfae49

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.