glance context is_admin role check is fragile

Bug #956547 reported by Brian Waldon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Brian Waldon

Bug Description

The is_admin check in the glance context checks for the role 'Admin', which is a very bad requirement to enforce. Devstack actually uses 'admin'. We should make the service admin role configurable

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5455

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/5455
Committed: http://github.com/openstack/glance/commit/eff04c5612e613580e89349858d3e9ae4f5cc64c
Submitter: Jenkins
Branch: master

commit eff04c5612e613580e89349858d3e9ae4f5cc64c
Author: Brian Waldon <email address hidden>
Date: Thu Mar 15 16:36:43 2012 -0700

    Add admin_role option

    * Allow a deployer to define the role that should give an authenticated
      user admin privileges. Defaults to 'admin'
    * Fixes bug 956547

    Change-Id: I018b9c438a12c527833ed8e2e6c377a93fde9130

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.