Rollback create_disk not catching StorageError

Bug #961762 reported by Rick Harris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Rick Harris

Bug Description

We're seeing 'Unable to destroy VDI OpaqueRef:f1134bd4-3d0b-8965-aecc-f3989c1e0dcf' errors triggered when the create_disks operation is rolled back.

The issue is that we're catching a XenAPI.Falure exception instead of StorageError which is what's being raised.

Since it's acceptable for the VDI to not exist yet, we should catch the StorageError and skip that particular VDI.

Changed in nova:
assignee: nobody → Rick Harris (rconradharris)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5653

Changed in nova:
assignee: Rick Harris (rconradharris) → Johannes Erdfelt (johannes.erdfelt)
Changed in nova:
assignee: Johannes Erdfelt (johannes.erdfelt) → Rick Harris (rconradharris)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/5653
Committed: http://github.com/openstack/nova/commit/298aac4bbf69c3c208673dbebb30c3e24396c3ca
Submitter: Jenkins
Branch: master

commit 298aac4bbf69c3c208673dbebb30c3e24396c3ca
Author: Rick Harris <email address hidden>
Date: Wed Mar 21 23:16:25 2012 +0000

    Rollback create_disks handles StorageError exception.

    Fixes bug 961762

    Change-Id: I146cecdd801a92b84adb4cc40bdf0a8c43950dd5

Changed in nova:
status: In Progress → Fix Committed
Devin Carlen (devcamcar)
Changed in nova:
milestone: none → folsom-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.