update.py doesn't handle dependencies of configured modules

Bug #963509 reported by Johannes Erdfelt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Wishlist
Zhongyue Luo

Bug Description

cfg.py now depends on iniparser.py, but update.py didn't automatically copy it. The dependencies can be figured out automatically and update.py could be friendlier and help out us poor developers.

Mark McLoughlin (markmc)
Changed in openstack-common:
status: New → Confirmed
importance: Undecided → Wishlist
Mark McLoughlin (markmc)
affects: openstack-common → oslo
Revision history for this message
Zhongyue Luo (zyluo) wrote :

I'll take a stab at this

Changed in oslo:
assignee: nobody → Zhongyue Luo (zyluo)
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

I won't say don't do this, but I wonder if the effort wouldn't be better spent just moving things into their own libraries so we can use the existing dependency management tools for installing.

Revision history for this message
Zhongyue Luo (zyluo) wrote :

I lost you from "just moving things into their own libraries". Do you have an example?

Revision history for this message
Johannes Erdfelt (johannes.erdfelt) wrote :

oslo.config?

https://pypi.python.org/pypi/oslo.config/1.1.0

My concern is that projects like nova use code out of oslo-incubator pretty early. We'll likely never switch over to only using released packages.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

Yes, exactly, like with oslo.config.

My understanding was that the plan was to keep the code out of the incubator repository once the first release was stable enough to make a separate library. So nova may use a development version of a library, but not by copying it out of the oslo-incubator.

Revision history for this message
Zhongyue Luo (zyluo) wrote :

Oh I understand now. This will just be a quick fix of an inconvenience I recently encountered. I'll abort if it seems too much of an effort.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

Sounds good. Like I said, I won't actively block it! :-)

Changed in oslo:
status: Confirmed → In Progress
Revision history for this message
Zhongyue Luo (zyluo) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/26322
Committed: http://github.com/openstack/oslo-incubator/commit/e396101c56d997aa8a710cc849ae3dc03cedfdfc
Submitter: Jenkins
Branch: master

commit e396101c56d997aa8a710cc849ae3dc03cedfdfc
Author: Zhongyue Luo <email address hidden>
Date: Mon Apr 8 01:07:47 2013 +0800

    Finds dependencies of configured modules for update.py

    Looks up import lines in the configures modules and finds dependencies.
    Did not load modules since it seemed as an overkill

    Fixes bug #963509

    Change-Id: I690cdf6fb149bbe243add3a35b96f6045ebe10f4

Changed in oslo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.