pt-query-digest dosn't fingerprint true/false literals correctly
Bug #965553 reported by
Rob Smith
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Frank Cizmich | ||
Bug Description
Query:
INSERT INTO tbl VALUES ( 123 , false, true, 456);
Distills to
INSERT INTO tbl VALUES ( ? , false, true, ?);
I believe the true/false literals should distill into ?s
This is with pt-query-digest 2.0.4
Related branches
lp:~percona-toolkit-dev/percona-toolkit/pt-query-digest-does-not-fingerprint-true-false-literals-correctly-965553
- Daniel Nichter: Approve
-
Diff: 364 lines (+89/-17)7 files modifiedbin/pt-index-usage (+18/-4)
bin/pt-kill (+18/-4)
bin/pt-query-digest (+3/-1)
bin/pt-table-usage (+18/-4)
bin/pt-upgrade (+18/-4)
lib/QueryRewriter.pm (+2/-0)
t/lib/QueryRewriter.t (+12/-0)
Revision history for this message
| Baron Schwartz (baron-xaprb) wrote | #1 |
| Changed in percona-toolkit: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in percona-toolkit: | |
| milestone: | none → 2.2.5 |
| summary: |
- pt-query-digest fails to distill true/false literals correctly + pt-query-digest dosn't fingerprint true/false literals correctly |
| Changed in percona-toolkit: | |
| milestone: | 2.2.5 → none |
| Changed in percona-toolkit: | |
| assignee: | nobody → Frank Cizmich (frank-cizmich) |
| milestone: | none → 2.2.8 |
| status: | Confirmed → In Progress |
| tags: | added: fingerprints |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
Agree -- that should be handled. I'm not sure how many cases like this there will be.