mutt-org crashed with SIGSEGV

StacktraceTop:
 mx_update_context (ctx=0xfc0710, new_messages=<optimized out>) at ../mx.c:1650
 imap_read_headers (idata=0x2a44500, msgbegin=<optimized out>, msgend=5) at ../../imap/message.c:386
 imap_open_mailbox (ctx=0xfc0710) at ../../imap/imap.c:756
 mx_open_mailbox (path=<optimized out>, flags=0, pctx=0x0) at ../mx.c:681
 mutt_index_menu () at ../curs_main.c:1186

mx.c:1650 in the (patched) source seems to refer to the comment preceding the declaration of mx_update_context. It's pretty safe to say the crash didn't actually occur on that line. ;-)

When this happens, relaunching mutt and opening the same mailbox always works fine. It's only after the notification of new messages that the crash occurs.

Status changed to 'Confirmed' because the bug affects multiple users.

What's needed is the more recent patch from the upstream bug. I linked a bzr branch wherein I applied the newer patch. I've never submitted a patch to lp before, not sure if I'm doing this right.

The attachment "mutt_1.5.21-5ubuntu3.debdiff" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

Thanks for the patch! I see this crash pretty regularly.

The upstream mutt bug reporter contains a comment regarding the following Debian bug report:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537694

That bug in Debian is fixed by the patch, debian/patches/upstream/537694-segv-imap-headers.patch, which is included in the Ubuntu package.

Oh, I see now Debian has the first patch from the upstream bug which doesn't seem to work.

I've reopened the debian bug regarding this issue as it would be good to have upstream fix their patch.

@Vibhav - your don't see to have used quilt properly in your debdiff as imap/message.c is still showing as being modified and your patch hasn't been added to the series file (debain/patches/series). Additionally, the original not work patch for this would need to be removed from the package too. I'll go ahead and take of these things.

Actually, there is a patch in debian that does cover this bug (well at least the upstream one like this) and its in version 1.5.21-5:

    + 584138-mx_update_context-segfault.patch: fix a segfault due to holes in
      IMAP headers, 537694-segv-imap-headers.patch is removed as part of this
      fix (Closes: 584138)

@Matt: is there any chance you could try to debdiff there and see if that fixes the issue for you,sponsor the update if it does?

@Brian: right, that patch is applied so it seems not enough, the upstream bug points to http://dev.mutt.org/trac/changeset/0e4f1782ea2e which is what the debdiff seems to include

On Mon, Jun 04, 2012 at 03:06:38PM -0000, Sebastien Bacher wrote:
> @Matt: is there any chance you could try to debdiff there and see if
> that fixes the issue for you,sponsor the update if it does?

I am running with the patch from comment #8 now. I don't have a reproducer,
but will watch for a while and see if the bug recurs.

--
 - mdz

I just got a similar looking crash while running with the patch from comment #8. :-/

apport won't report it because it's an obsolete package, but based on the user-visible symptoms I think it's a similar problem.

There is a setting to override the obsolete package check:

    # check obsolete packages
    if report['ProblemType'] == 'Crash' and \
        'APPORT_IGNORE_OBSOLETE_PACKAGES' not in os.environ:

On Wed, Jun 20, 2012 at 05:46:28PM -0000, Brian Murray wrote:
> There is a setting to override the obsolete package check:
>
> # check obsolete packages
> if report['ProblemType'] == 'Crash' and \
> 'APPORT_IGNORE_OBSOLETE_PACKAGES' not in os.environ:

Yes, and I tried to use it, but it didn't work for me (anymore). I've used
it many times successfully in the past, e.g. by running
APPORT_IGNORE_OBSOLETE_PACKAGES=1 apport-cli <path to .crash file>.

--
 - mdz

Given that there is still debate about the patch, I'm not sure there is anything for ubuntu-sponsors to do at this point. Perhaps upstream should be involved before we upload something?

Agreed; unsubscribing sponsors for now. Resubscribe once there's consensus on a solution.

I suspect this may also be a dup of open bug #666286 and open bug #861056

I found these after I had this same crash today. I can force Mutt to crash via a different mechanism though, via a notmuch-mutt call and doing a search for a popular word.