pyjuju

Unable to deploy charm that uses symbolic links from the charm store

Bug #973260 reported by James Page
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pyjuju
Fix Released
Critical
William Reade

Bug Description

juju deploy zookeeper

results in a service unit with 'install-error' status.

The charm uses a common hook (zookeeper-common) with symbolic links for the supported hooks.

These get broken in the deployed service unit - each is a simple file with the text "zookeeper-common".

The zip file in ~/.juju/cache for the charm contains symbolic links.

Related branches

lp:~fwereade/pyjuju/fix-charm-symlinks
Juju Engineering: Pending requested
Diff: 120 lines (+36/-11)
4 files modified
juju/charm/base.py (+0/-5)
juju/charm/bundle.py (+4/-4)
juju/charm/directory.py (+3/-2)
juju/charm/tests/test_bundle.py (+29/-0)
William Reade (fwereade)
Changed in juju:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → William Reade (fwereade)
milestone: none → florence
William Reade (fwereade)
Changed in juju:
milestone: florence → honolulu
status: Confirmed → In Progress
William Reade (fwereade)
Changed in juju:
status: In Progress → Fix Released
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Re: [Bug 973260] Re: Unable to deploy charm that uses symbolic links from the charm store

Excerpts from William Reade's message of Wed Apr 04 12:33:05 UTC 2012:
> ** Changed in: juju
> Status: In Progress => Fix Released
>

William, could you perhaps document the commit that fixed this, and
provide a brief synopsis? Thanks!

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

Excerpts from Clint Byrum's message of 2012-04-04 17:39:07 UTC:
> Excerpts from William Reade's message of Wed Apr 04 12:33:05 UTC 2012:
> > ** Changed in: juju
> > Status: In Progress => Fix Released
> >
>
> William, could you perhaps document the commit that fixed this, and
> provide a brief synopsis? Thanks!
>

------------------------------------------------------------
revno: 511 [merge]
author: William Reade <email address hidden>
committer: William Reade <email address hidden>
branch nick: juju
timestamp: Wed 2012-04-04 14:29:56 +0200
message:
  When extracting charms, use only filetype mode bits to detect symlinkicity

  We had been writing, and checking for, a magic value (in external_attr)
  which happened to equal `(stat.S_IFLNK | 0755) << 16`; the charm store was
  giving us one equal to `(stat.S_IFLNK | 0777) << 16`, and we weren't
  considering that to be a symlink. We now just check the filetype and ignore
  permissions on symlinks.

  R=hazmat
  CC=
  https://codereview.appspot.com/5980045
modified:
  juju/charm/base.py
  juju/charm/bundle.py
  juju/charm/directory.py
  juju/charm/tests/test_bundle.py

Clint Byrum (clint-fewbar)
Changed in juju:
milestone: honolulu → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.