OpenStack Core Infrastructure

Bring back alternate row shading in Gerrit

Bug #996390 reported by Andrew Hutchings
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Released
Wishlist
Andrew Hutchings
OpenStack Core Infrastructure folsom

Bug Description

From Kevin L. Mitchell (klmitch):

"I personally would like to see alternating colors, because that makes it easier to see at a glance, without having to actively do something."

Previously we did this using CSS but since there are not many IDs to anchor this on it broke many other things. Suggest instead we do this by patching Gerrit and making it 2 colour options with default as both white so that this will look the same by default. It also means the click-to-highlight is compatible.

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

based on comment from bug #848405

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gerrit (openstack/2.4.1)

Fix proposed to branch: openstack/2.4.1
Review: https://review.openstack.org/8607

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gerrit (openstack/2.4.1)

Reviewed: https://review.openstack.org/8607
Committed: http://github.com/openstack-ci/gerrit/commit/8b48c79c978b6594aba1ccc332fed5256920409b
Submitter: Jenkins
Branch: openstack/2.4.1

commit 8b48c79c978b6594aba1ccc332fed5256920409b
Author: Andrew Hutchings <email address hidden>
Date: Fri Jun 15 14:53:28 2012 +0100

    Add odd/even row coloring

    Adds two variables (tableOddRowColor and tableEvenRowColor), both
    background color by default

    Suggested config values:
    tableOddRowColor = ffffff
    tableEvenRowColor = f5f5ff

    Fixes bug #996390

    Change-Id: I956791ff528f4dabec777017515e208d3bc130e3

Andrew Hutchings (linuxjedi)
Changed in openstack-ci:
status: Triaged → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gerrit (openstack/2.4.2)

Fix proposed to branch: openstack/2.4.2
Review: https://review.openstack.org/9136

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gerrit (openstack/2.4.2)

Reviewed: https://review.openstack.org/9136
Committed: http://github.com/openstack-ci/gerrit/commit/25c98e68759a76a9e64ded29ad2037681131db78
Submitter: Jenkins
Branch: openstack/2.4.2

commit 25c98e68759a76a9e64ded29ad2037681131db78
Author: Andrew Hutchings <email address hidden>
Date: Fri Jun 15 14:53:28 2012 +0100

    Add odd/even row coloring

    Adds two variables (tableOddRowColor and tableEvenRowColor), both
    background color by default

    Suggested config values:
    tableOddRowColor = ffffff
    tableEvenRowColor = f5f5ff

    Fixes bug #996390

    Change-Id: I956791ff528f4dabec777017515e208d3bc130e3

Andrew Hutchings (linuxjedi)
Changed in openstack-ci:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gerrit (openstack/2.4.4)

Fix proposed to branch: openstack/2.4.4
Review: https://review.openstack.org/35442

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gerrit (openstack/2.4.4)

Reviewed: https://review.openstack.org/35442
Committed: http://github.com/openstack-infra/gerrit/commit/a75cd2a98ae693f00442549bc05bad03a6b7e362
Submitter: Jenkins
Branch: openstack/2.4.4

commit a75cd2a98ae693f00442549bc05bad03a6b7e362
Author: Andrew Hutchings <email address hidden>
Date: Fri Jun 15 14:53:28 2012 +0100

    Add odd/even row coloring

    Adds two variables (tableOddRowColor and tableEvenRowColor), both
    background color by default

    Suggested config values:
    tableOddRowColor = ffffff
    tableEvenRowColor = f5f5ff

    Fixes bug #996390

    Change-Id: I956791ff528f4dabec777017515e208d3bc130e3

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.