Ubuntu
firefox package

underquoted definition of automake macros

Bug #36659 reported by Jan Arne Petersen
10
Affects Status Importance Assigned to Milestone
Mozilla Firefox
Fix Released
Medium
firefox (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

/usr/share/aclocal/nspr.m4:8: warning: underquoted definition of AM_PATH_NSPR

See original description
Revision history for this message
In , Pw-fb (pw-fb) wrote :

Created attachment 187022
as mentioned in original report

Revision history for this message
In , Wan-Teh Chang (wtc-google) wrote :

Chris, could you review this bug report? Thanks.

Revision history for this message
Jan Arne Petersen (jpetersen) wrote :

/usr/share/aclocal/nspr.m4:8: warning: underquoted definition of AM_PATH_NSPR

Revision history for this message
Jan Arne Petersen (jpetersen) wrote : Patch to fix underquoted automake macros

Patch to fix underquoted automake macros.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Ian, that bug as a simple patch, maybe it could be considered?

Changed in firefox:
assignee: nobody → ijackson
Revision history for this message
In , Ian Jackson (iwj) wrote :

Created attachment 218036
patch to fix some more AC_DEFUN instances

This mistake was reported by an Ubuntu user in our bug system, at
 https://launchpad.net/distros/ubuntu/+source/firefox/+bug/36659

I grepped the firefox 1.5.0.1 source tree for AC_DEFUN and fixed all of the instances that that found - there were twenty.

Revision history for this message
In , Wan-Teh Chang (wtc-google) wrote :

Comment on attachment 218036
patch to fix some more AC_DEFUN instances

Ben, if m4 macros are not your area, please ask cls
to review this patch. Thanks.

Revision history for this message
In , Wan-Teh Chang (wtc-google) wrote :

Comment on attachment 187022
as mentioned in original report

I checked in this nspr.m4 patch on the NSPR trunk (NSPR 4.7)
and NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.9 alpha).

Revision history for this message
In , Cls-seawood (cls-seawood) wrote :

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=&branchtype=match&dir=&file=&filetype=match&who=cls%25seawood.org&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-05-15+22%3A35%3A00+PDT&maxdate=2006-05-15+22%3A40%3A00+PDT&cvsroot=%2Fcvsroot

Revision history for this message
In , Cls-seawood (cls-seawood) wrote :

Sorry, Ian. I gave improper attribution in the checkin comment.

Revision history for this message
In , Niederstrasser (niederstrasser) wrote :

Any chance this could go into the 1.8 branch? It seems very low risk.

Ian Jackson (ijackson)
Changed in firefox:
assignee: ijackson → nobody
Revision history for this message
John Vivirito (gnomefreak) wrote :

Is this still and issue for you? We are trying to trying sort out the older Mozilla issues and would like to know if this still happens

Changed in firefox:
status: Unconfirmed → Needs Info
Revision history for this message
Jan Arne Petersen (jpetersen) wrote :

It is fixed.

Revision history for this message
John Vivirito (gnomefreak) wrote :

Thank you

Changed in firefox:
status: Needs Info → Fix Released
Revision history for this message
In , Wan-Teh Chang (wtc-google) wrote :

*** Bug 375285 has been marked as a duplicate of this bug. ***

Bug Watch Updater (bug-watch-updater)
Changed in firefox:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.