[not archive admin] nano: cannot save in "crontab -e" if backup is enabled

Reported via reportbug by:
Bill Marcum <email address hidden>

I see this in Debian too. I'm taking this upstream.

This is fixed in the latest nano in unstable/etch. Needs to be backported to 1.3.10 due to UVF.

Ok, after a brief chat in #u-d, I bring this to ubuntu-release to see what they prefer.

This bug is fixed in Debian, but I fear I won't have the time to create a new source for dapper before things start to close for the release.

We either want a UVF and sync with Debian, or get someone to backport the relevant patches to this version.

1.3.11 has been rock solid in Debian for weeks already, and there were no major changes in that version. nano is entering freeze next week for 2.0, actually.

release team, please tell me what you prefer.

Please send the upstream changelog excerpt for 1.3.11.

--
 - mdz

GNU nano 1.3.11 - 2006.03.30
- General:
        - Miscellaneous comment fixes. (DLR)
        - Remove unnecessary #ifdef around termios.h #include in nano.c.
          (DLR)
        - Sort the default strings for brackets and punct, and the "or"
          atom in the default regex string for quotestr, according to
          ASCII. Changes to main(), nano.1, nanorc.5, and
          nanorc.sample. (DLR)
        - Rework the bracket searching code to handle multibyte bracket
          characters, and allow specifying matching bracket characters
          other than the default via the "matchbrackets" rcfile option.
          New functions mbstrpbrk() and mbrevstrpbrk(); changes to
          find_statusbar_bracket_match(), do_statusbar_find_bracket(),
          find_bracket_match(), do_find_bracket(), main(),
          parse_rcfile(), nanorc.5, and nanorc.sample. (DLR)
        - Rework input parsing in the file browser to be more flexible.
          New function parse_browser_input(); changes to do_browser().
          (DLR)
        - Allow tab completion of directories at the "Go To Directory"
          prompt. Also, move the browser drawing routines to a separate
          function, and make sure it's used when refreshing or doing tab
          completion at the prompt in the file browser. New function
          browser_refresh(); changes to do_browser(), browser_init(),
          do_insertfile(), do_writeout(), cwd_tab_completion(),
          input_tab(), do_statusbar_input(), get_prompt_string(),
          do_prompt(), search_init(), do_replace(), do_gotolinecolumn(),
          and do_int_spell_fix(). (DLR)
- browser.c:
  do_browser()
        - Properly set currshortcut back to the file browser shortcut
          list after a "Go To Directory" prompt, and properly restore
          the file list display after returning from the help browser at
          the "Go To Directory" prompt. (DLR)
        - Rename variable j to i, for consistency. (DLR)
        - Make fileline, old_selected, and the static selected size_t's,
          since the first and second can hold the value of the third,
          and the first can be that large. (DLR)
- chars.c:
  mbstrchr()
        - Make parameter c const. (DLR)
- files.c:
  do_writeout()
        - Remove unneeded setting of currshortcut. (DLR)
  is_dir()
        - Rename parameter ret to retval, for consistency. (DLR)
- global.c:
  shortcut_init()
        - Remove erroneous handling of the "Get Help" shortcut in the
          file browser shortcut list. (DLR)
- nano.h:
        - Remove now-unneeded VERMSG #define. (DLR)
- prompt.c:
  get_prompt_string()
        - Redraw the prompt and set finished to FALSE when NANO_HELP_KEY
          is pressed, so that we don't leave the prompt, enter the help
          browser, and restart the prompt after leaving it. This will
          properly preserve the cursor position after doing the last of
          these. (DLR)
- utils.c:
  ngetdelim()
        - Do sanity checks manually again instead of in an assert, and
          set errno to EINVAL as well as return -1 if they fail. This
          matches the...

Looks fine, go ahead.

--
 - mdz

This change makes it impossible to sync this package directly:

  * debian/control: generate udeb dependencies automatically, using a newer
    debhelper and dpkg-dev. Thanks, Frans Pop (closes: #360265). The correct
    dpkg-dev is pulled by debhelper, so backporters can just ignore the
    newer debhelper build-dep.

We aren't pulling in the udeb library dependency work for Dapper, and this change would fail to build because we (intentionally) don't have a new enough debhelper. Please get a main uploader to upload 1.3.11-1 plus any important changes from 1.3.11-2 by hand.

mdz, I discussed with upstream about what patches should be included in a final nano release for dapper, and he provided 3 more patches from CVS, to fix very specific issues.

I have uploaded -3 to Debian, and if you or Kamion could eyeball them, I will find a sponsor for -3ubuntu1 early tomorrow, which will revert the udeb changes.

If not, I can just go -2ubuntu1.

mdz, I did not realise a nano upload would mean a new d-i upload. While the original bug described here is pretty bad (can't edit crontab with nano + backup enabled), tabs enabled isn't the default configuration. The other bugs can even cause segfaults, but they are clearly minor.

You tell us if we still do an upload.

On Thu, May 18, 2006 at 10:42:34PM -0000, Jordi Mallach wrote:
> mdz, I did not realise a nano upload would mean a new d-i upload. While
> the original bug described here is pretty bad (can't edit crontab with
> nano + backup enabled), tabs enabled isn't the default configuration.
> The other bugs can even cause segfaults, but they are clearly minor.
>
> You tell us if we still do an upload.

If it complicates the installer and is not a major bug, I would prefer not
to change it.

You could of course ship a new nano in dapper-updates after the release.

--
 - mdz

Seems to be fixed in feisty; closing bug.