Comment 10 for bug 1205263

Revision history for this message
Martin Pitt (pitti) wrote :

I'm afraid I'm the wrong person to ask about this, I don't know about audio hardware power management. Just some thoughts:

 * If it's safe to turn on power saving on battery mode after 1 (or 10, as in above suggestion) seconds, why isn't it safe to do it on AC as well? Are there some drawbacks like a long wakeup time, or anything else which causes a noticeable regression in that mode? Or is that still the potential click/pop problem as pointed out in http://www.mjmwired.net/kernel/Documentation/sound/alsa/powersave.txt ?

 * We don't want click/pop noises on battery either. Are we actually aware of that happening, from bug reports etc? It seems to me that we should enable audio power saving on hardware where it's safe to do so, not depending on battery mode.

 * Thirdly, above documentation actually suggests that "1" is a bad default, so in the powersaving case we should change that to 10.

So perhaps we could start with changing the hook to ignore the $1 argument (i. e. whether on powersave mode or not), and instead enable power_save = 10 on known-good devices/drivers at least for an SRU? For the development series we could actually set it to 10 always and send a call for testing to watch out for click/pop noises?