1. Renames "webservice_enabled" config to "webservice_provider_enabled",
to indicate that this config only controls Mahara's actions as
a webservice provider, *not* a webservice client.
2. Renames all the "webservice_<protocol>_enabled" configs to
"webservice_provider_<protocol>_enabled" to indicate that they only
control whether Mahara will provide webservices via that protocol,
and not whether Mahara will use that protocol as a client.
3. Renames "webservice_connections_enabled" config to
"webservice_requester_enabled", to clarify that this config
controls whether Mahara is allowed to request webservices
from external sources.
4. Updates language strings to make these changes clearer.
5. Rearranges and renames the form methods in
webservice/admin/index.php to make the flow of control more
obvious. Now the main form method is first, followed in order
by the methods that generate its subforms and each of their
submit handlers.
Reviewed: https:/ /reviews. mahara. org/6720 /git.mahara. org/mahara/ mahara/ commit/ ce1a97ac9ebbe80 d5d9e0d116263ca 156a6d8a71
Committed: https:/
Submitter: Robert Lyon (<email address hidden>)
Branch: master
commit ce1a97ac9ebbe80 d5d9e0d116263ca 156a6d8a71
Author: Aaron Wells <email address hidden>
Date: Thu Jul 14 18:54:24 2016 +1200
Bug 1600099: Cleanup of the webservice admin page
This patch does a few things:
1. Renames "webservice_ enabled" config to "webservice_ provider_ enabled" ,
to indicate that this config only controls Mahara's actions as
a webservice provider, *not* a webservice client.
2. Renames all the "webservice_ <protocol> _enabled" configs to provider_ <protocol> _enabled" to indicate that they only
"webservice_
control whether Mahara will provide webservices via that protocol,
and not whether Mahara will use that protocol as a client.
3. Renames "webservice_ connections_ enabled" config to requester_ enabled" , to clarify that this config
"webservice_
controls whether Mahara is allowed to request webservices
from external sources.
4. Updates language strings to make these changes clearer.
5. Rearranges and renames the form methods in admin/index. php to make the flow of control more
webservice/
obvious. Now the main form method is first, followed in order
by the methods that generate its subforms and each of their
submit handlers.
behatnotneeded: Covered by existing tests
Change-Id: I58dadb352d1f15 42ca67a104ebfd7 02b4ca90fc9