Improving webservices connection manager user interface

Bug #1600099 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

While testing out the new webservices connection manager (Bug 1393536), I noticed a few areas of the user interface that could use some improvement.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Do you want to elaborate on these? I know I have to change some language strings. Unfortunately, I didn't get this done before you committed the feature. Any info on improving the interface would be great because then we can ask Liam and Pat to do that.

Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 16.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6714

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/6715

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6714
Committed: https://git.mahara.org/mahara/mahara/commit/c494940df142407403c57d89b02ec7115ac77896
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c494940df142407403c57d89b02ec7115ac77896
Author: Aaron Wells <email address hidden>
Date: Tue Jul 12 20:18:44 2016 +1200

Bug 1600099: Hide the institution connections link if no connection definitions

If the site doesn't yet have any plugins installed that define webservice
connections, then the institution connection manager screen can't be used.
In which case, we should hide the link to avoid confusing users.

Change-Id: Ia9351995485331ea5d6fc94fcdf69eafbfa18c01
behatnotneeded: Can't readily test in Behat

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6720

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6720
Committed: https://git.mahara.org/mahara/mahara/commit/ce1a97ac9ebbe80d5d9e0d116263ca156a6d8a71
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ce1a97ac9ebbe80d5d9e0d116263ca156a6d8a71
Author: Aaron Wells <email address hidden>
Date: Thu Jul 14 18:54:24 2016 +1200

Bug 1600099: Cleanup of the webservice admin page

This patch does a few things:

1. Renames "webservice_enabled" config to "webservice_provider_enabled",
to indicate that this config only controls Mahara's actions as
a webservice provider, *not* a webservice client.

2. Renames all the "webservice_<protocol>_enabled" configs to
"webservice_provider_<protocol>_enabled" to indicate that they only
control whether Mahara will provide webservices via that protocol,
and not whether Mahara will use that protocol as a client.

3. Renames "webservice_connections_enabled" config to
"webservice_requester_enabled", to clarify that this config
controls whether Mahara is allowed to request webservices
from external sources.

4. Updates language strings to make these changes clearer.

5. Rearranges and renames the form methods in
webservice/admin/index.php to make the flow of control more
obvious. Now the main form method is first, followed in order
by the methods that generate its subforms and each of their
submit handlers.

behatnotneeded: Covered by existing tests

Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.