Comment 17 for bug 921442

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Dear OpenERP Team,

I can understand you need merge proposal and test case to handle your stuff. Sometimes, it is not that easy to write a proper one in Yaml, especially here. Can I just remind you gently that you never write one test for this module as well ?! This is just because we can't actualy do it, or we will just spend weeks on it. Code a mail sending test and I will include my test case in it I promise !

I try a last time to convince you here by proposing a patch and instructions to reproduce the bug :

1 ) Install a fresh OpenERP DB

2) Install and configure the CRM + mail interface

3) Setup an Incoming mail server on any test mail account you have (let's say <email address hidden>)

4) Send an email @ <email address hidden>

5) Apply the "reproduce.patch" on the server and restart it

6) Ask to fetch the email through : Settings -> Configuration -> Email -> Incoming Mail Server by clicking the "Fetch Now" button

You'll have an error raised by Postgres cause of UTF-8 decoding trouble (here a copy of postgres logs:
ERROR: invalid byte sequence for encoding "UTF8": 0xff
ERROR: current transaction is aborted, commands ignored until end of transaction block
)

Now you can retry the same procedure with my second patch "reproduce_fixed.patch" (that include my fix) and you'll see you're not gonna have this crash anymore.

Now, I take the time to discuss the trouble, I even provide a patch on a feature that is quite important and crucial (even for your own infrastructure, as you also use the CRM for OPW support case).

You now have the possibility to reproduce it... Take your own decision. I have taken my own and committed my patch in our Camptocamp's branch. You can merge it if you want, but I won't request a merge myself for that case :

bzr merge -c6589 https://code.launchpad.net/~c2c/openobject-addons/6.1-c2c-official

Regards,

Joël