Malone messes up comment formatting

Bug #3002 reported by Sebastien Bacher
36
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Matthew Paul Thomas

Bug Description

Some backtrace examples:
https://launchpad.net/distros/ubuntu/+source/evolution/+bug/3001
https://launchpad.net/distros/ubuntu/+source/gnome-utils/+bug/2744

Some new lines are not placed correctly on the page which makes ugly comments.

See also bug 29569 for other suggestions from iwj.

Tags: lp-bugs
Brad Bollenbach (bradb)
description: updated
Revision history for this message
Brad Bollenbach (bradb) wrote :

This looks to me like normal HTML wrapping, even though it's ugly.

Are you expecting that the text should cross into the imaginary white gutters that exist on each side of almost every single page in Launchpad? Or perhaps you're suggesting that portlets on both sides take up so much space that formatting bug comments is a mess? Or something else?

Changed in malone:
status: New → NeedInfo
Revision history for this message
Sebastien Bacher (seb128) wrote :

I'm expecting to have one line by # for a backtrace. Look on the gnome-utils example, it has #4 #5 #6 on the same line, which is quite annoying to read the backtrace

Changed in malone:
status: NeedInfo → New
Revision history for this message
Stuart Bishop (stub) wrote :

(From Bug 5157, which has been flagged as a duplicate of this one)

Bug descriptions and comments should be in a fixed width font preserving whitespace formatting - it should look identical to the way it was entered in the web form or in the user's email client.

Brad Bollenbach (bradb)
Changed in malone:
status: New → Accepted
Revision history for this message
Stuart Bishop (stub) wrote :

Another example is the second comment in Bug 5814. Malone decided to second guess me and format my list into a paragraph.

This is broken. It is impossible for Malone to infer meaning from plain ascii input without standardizing on some sort of markup (which would cause worse problems). The information just doesn't exist.

Brad Bollenbach (bradb)
description: updated
Changed in malone:
assignee: nobody → mpt
Changed in malone:
status: Confirmed → In Progress
Changed in malone:
status: In Progress → Fix Committed
Changed in malone:
status: Fix Committed → Fix Released
Revision history for this message
John A Meinel (jameinel) wrote :

As for bug #5157, the web form seems to use a variable-width font, while the comments themselves use a fixed-width font. Is this fixable? Or is it a problem with Firefox?

The other problem I've run into with whitespace, is that malone normalizes whitespace inside a line. It doesn't normalize the whitespcae at the start of a line. So in this example, all lines are the same width:

1234567
abcdefg
a c e g
a d g
   d g
      g

I mostly notice this when I submit a 1-line patch as a fix. It is usually nice to have a lot of context (surrounding lines, and the line number and filename) which 'diff' does a very good job of.
I realize I can save the patch to a file, and upload it separately, but that is a fairly high amount of overhead for submitting a one-line fix, and also makes it difficult to discuss it, as the patch is not on the same page.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.