> 1) We do need the same logic applied to empathy-status-icon.c, without it we don't get notifications when the chat window isn't open. Can you apply the same logic there?
I'll try to do this
> 2) It works well for IMs from one person, but if you have incoming IMs within the timeout period one of the notifications seems to get discarded. So it appends the notifications for the existing notification nicely, but new notifications from other people seem to not appear at all, even after the existing one expires.
This is strange, the only thing I can say is that maybe the mutex
gives problems.
Let's first add the same logic to empathy-status-icon.c and see what happens.
Hi, I'm glad you already reviewed the patch!
> 1) We do need the same logic applied to empathy- status- icon.c, without it we don't get notifications when the chat window isn't open. Can you apply the same logic there?
I'll try to do this
> 2) It works well for IMs from one person, but if you have incoming IMs within the timeout period one of the notifications seems to get discarded. So it appends the notifications for the existing notification nicely, but new notifications from other people seem to not appear at all, even after the existing one expires.
This is strange, the only thing I can say is that maybe the mutex status- icon.c and see what happens.
gives problems.
Let's first add the same logic to empathy-