Comment 8 for bug 523041

Revision history for this message
Martin Pitt (pitti) wrote :

This patch should be written more robustly. It initializes icon->priv->app_indicator = app_indicator_new() without ever checking for success, or NULL, and all the new code which accesses this does not do anything like g_assert() or g_return_if_fail() if the indicator is NULL. It should just fall back to the current upstream behaviour (showing its own tray icon) if initializing the indicator fails.