Comment 8 for bug 119675

Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks for this, Tormod - sorry I took so long to review it! I've uploaded your package with just two changes.

Firstly, use "LP: #nnnnn" rather than "Ubuntu #nnnnn" or any other similar syntax to refer to fixed bugs; using that exact syntax causes Launchpad to close the bugs automatically on upload, which is convenient. If you happen to use vim, then gutsy's version will highlight that; otherwise, look for Launchpad-Bugs-Fixed in the .changes file.

Secondly, please apply patches to debian/* directly rather than via debian/patches/*; having a patch applied to debian/* at build time is generally considered confusing. I know that debian/patches/ubuntu_update_grub.diff already patches debian/update-grub, but that's not actually applied and only kept around for reference in case we're ever crazy enough to reapply it.

Otherwise, good job!