Comment 28 for bug 356631

Revision history for this message
Martin Pitt (pitti) wrote : Re: [Bug 356631] Re: CD-ROM tray closes automatically after eject

Scott James Remnant [2009-04-20 14:38 -0000]:
> But the hack fix is not going to go upstream, and you specifically
> suggested sending it upstream.

I don't consider it a hack at all. It's a matter of style or opinion
whether you expect the track/session counts to have any meaning if
there is no CD in the drive at all. As I said, you could set the
values to zero in the kernel driver, or entirely ignore them in udev
if there's no CD. I don't see why the latter should be a hack; in
fact, in the "be liberal what you accept" programming practice it's
even the better solution, since it would allow newer udevs to run on
older kernels, too.

> I'm personally nervous about making a change to the *standard* udev
> rules that hasn't been confirmed with the kernel maintainer of that
> subsystem, and tested properly.

It was successfully tested above, and is really quite obvious, no?

> Remember, these rules are used by all subscribing distros not just
> Ubuntu.

That's the intent. I guess other distros are happy about this fix as
well.

> If there's a problem with them, or with the kernel, we should have a
> much wider discussion net than just a bug that's fast-tracked into
> an Ubuntu SRU.

I'd like to, but it's just about impossible to find an upstream bug
tracker for udev -- it's not on bz.kernel.org, not in copyright, not
linked in Launchpad, and google reveals nothing helpful either. Where
should I send it to?