Comment 10 for bug 1152187

Hello Michael, Matthias,

thanks for the review!

Michael Terry [2013-03-14 16:18 -0000]:
> * Existing bugs seem tolerable (most of them deal with the init
> pieces anyway). Should keep a watch on Debian bug 701364, which
> says it ftbfs with gcc-4.8.

I built current master and 198 with gcc-4.8, works fine. The Debian
bug has a link to the upstream commit.

> * Uses python2, but does so with dh_python2 and the python-systemd
> package is not likely to be pulled onto the Desktop CD, so that's
> fine.

Right, that's supposed to stay in universe for now.

> The one big beef I have is that we don't run any of the unit tests,
> because some of them fail (pitti says they make assumptions that aren't
> true on Ubuntu). I'd like to see those fixed or the rest of the unit
> tests enabled, so we have at least some coverage.

I fixed and enabled unit tests during package build, works fine now:
http://people.canonical.com/~pitti/tmp/systemd-patches/0011-Fix-and-reenable-unit-tests.patch
This will be part of the next systemd upload.

Matthias Klose [2013-03-15 4:58 -0000]:
> - is there a reason not to provide a python3-systemd package?

It doesn't currently build with PYTHON=python3.

> - gcc-4.8 can be found in the ubuntu-toolchain-r ppa

See above, I tested with gcc-4.8 and it works fine.

> - just want to clarify that the MIR is currently not done for the
> systemd package, which I assume will stay in universe.

We don't even build systemd and systemd-sysv binaries on Ubuntu, for
mostly political reasons. But I'm wary of bringing this up over and
over again, so I don't intend to enable them for universe for the time
being.

Thanks,

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)