Ubuntu
thermald package

  1. Bug #1995606
  2. Comment #10

Comment 10 for bug 1995606

Revision history for this message
Chris Halse Rogers (raof) wrote :

Hi there! Sorry for the delay in getting to this. Some review:
*) It'd be easier to review if debian/changelog mentioned each of the patches and what they do. For example, rather than having the changelog entry:
  * Support ITMTv2 for Raptor Lake (LP: #2007579)
you could have the changelog entries:
  * debian/patches/0003-Parse-ITMT-Table.patch:
  * debian/patches/0006-Install-ITMT-target.patch:
  * debian/patches/0018-Process-ITMT-v2.patch:
    - Support ITMTv2 for Raptor Lake (LP: #2007579)

Since you know why you selected the patches you've added, this means I don't need to try and reverse-engineer what bug each of the patches is trying to address.

*) 0015-Ensure-there-is-one-trips-element-per-zone.patch: Why is this patch here? It looks to me like it's patching code that we don't build?

Overall this looks like it's mostly there; it's not entirely clear to me what *all* the patches are for, but it looks like they're (mostly) sensible patches.