Comment 5 for bug 225520

Revision history for this message
In , Hugues Fournier (hugues-fournier) wrote :

I have located the checkin that introduced this regression.

The regression appeared between build 2008-01-29-04-trunk and build 2008-01-29-04-trunk
The probable suspect seemed to be the checkin that resolved bug 66057 :
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/base/src/nsProtocolProxyService.cpp&rev=1.74&root=/cvsroot
(that had been checked in, then backed out, then relanded on January 29)

And it was..

Since this checkin, ConfigureFromPAC exits if the uri is the same than the one already known, this is an intended behaviour:
"Switch to new PAC file if that setting has changed. If the setting hasn't changed, ConfigureFromPAC will exit early." (comment in the new code of Resolve_Internal introduced in this checkin)

The problem is that ConfigureFromPAC is called from ReloadPAC() too.