Merge lp:~unity-team/unity8/flickables-speed-workaround into lp:unity8

Proposed by Andrea Cimitan
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 1243
Merged at revision: 1362
Proposed branch: lp:~unity-team/unity8/flickables-speed-workaround
Merge into: lp:unity8
Diff against target: 747 lines (+157/-44)
32 files modified
qml/Components/Carousel.qml (+2/-3)
qml/Components/Flickables/Flickable.qml (+23/-0)
qml/Components/Flickables/GridView.qml (+25/-0)
qml/Components/Flickables/ListView.qml (+25/-0)
qml/Components/Flickables/ListViewWithPageHeader.qml (+23/-0)
qml/Components/ResponsiveGridView.qml (+2/-1)
qml/Components/ZoomableImage.qml (+2/-2)
qml/Dash/CardHorizontalList.qml (+2/-1)
qml/Dash/DashContent.qml (+2/-3)
qml/Dash/DashNavigationButton.qml (+2/-1)
qml/Dash/DashNavigationList.qml (+2/-1)
qml/Dash/PageHeader.qml (+2/-1)
qml/Dash/PreviewListView.qml (+2/-3)
qml/Dash/Previews/Preview.qml (+2/-1)
qml/Dash/Previews/PreviewImageGallery.qml (+3/-2)
qml/Dash/ScopeListView.qml (+3/-6)
qml/Dash/ScopeSettingsPage.qml (+2/-1)
qml/Dash/ScopesOverviewAll.qml (+2/-1)
qml/Dash/ScopesOverviewFavorites.qml (+4/-2)
qml/Greeter/LoginList.qml (+2/-2)
qml/Hud/Hud.qml (+2/-1)
qml/Hud/HudParametrizedActionsPage.qml (+2/-1)
qml/Launcher/LauncherPanel.qml (+2/-1)
qml/Notifications/Notification.qml (+2/-1)
qml/Notifications/Notifications.qml (+2/-1)
qml/Panel/IndicatorRow.qml (+2/-1)
qml/Panel/Indicators/DefaultIndicatorPage.qml (+2/-1)
qml/Panel/Indicators/client/IndicatorsList.qml (+2/-1)
qml/Panel/Indicators/client/IndicatorsTree.qml (+2/-1)
qml/Panel/MenuContent.qml (+3/-2)
qml/Stages/PhoneStage.qml (+2/-1)
qml/Stages/TabletStage.qml (+2/-1)
To merge this branch: bzr merge lp:~unity-team/unity8/flickables-speed-workaround
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
Review via email: mp+237944@code.launchpad.net

This proposal supersedes a proposal from 2014-09-11.

Commit message

Fix flickable speed to be resolution independent, by subclassing components

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
 * Did you make sure that your branch does not contain spurious tags?
Yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Text conflict in debian/control
Text conflict in plugins/Dash/CardCreator.js
Text conflict in qml/Dash/GenericScopeView.qml
Text conflict in qml/Dash/ScopeSettingsPage.qml
Text conflict in qml/Panel/Indicators/DefaultIndicatorPage.qml
Text conflict in qml/Panel/MenuContent.qml
Text conflict in tests/plugins/Dash/cardcreator/2.res
Text conflict in tests/plugins/Dash/cardcreator/7.res
Text conflict in tests/qmltests/Dash/tst_GenericScopeView.qml
9 conflicts encountered.

review: Needs Fixing
1243. By Andrea Cimitan

Attempt to merge

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Ok, code looks reasnoable for a workaround and on the phone it feels ok, so if this is the workaround we want, let's go with it.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
No, because it's broken in trunk

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/Components/Carousel.qml'
--- qml/Components/Carousel.qml 2014-07-08 17:49:18 +0000
+++ qml/Components/Carousel.qml 2014-10-10 11:46:46 +0000
@@ -17,6 +17,7 @@
17import QtQuick 2.017import QtQuick 2.0
18import Ubuntu.Components 0.118import Ubuntu.Components 0.1
19import "carousel.js" as CarouselJS19import "carousel.js" as CarouselJS
20import "Flickables" as Flickables
2021
21/*! The Carousel component presents the items of a model in a carousel view. It's similar to a22/*! The Carousel component presents the items of a model in a carousel view. It's similar to a
22 cover flow. But it stops at it's boundaries (therefore no PathView is used).23 cover flow. But it stops at it's boundaries (therefore no PathView is used).
@@ -63,7 +64,7 @@
63 and footer item to compensate that.64 and footer item to compensate that.
6465
65 The scaling of the items is controlled by the variable continuousIndex, described below. */66 The scaling of the items is controlled by the variable continuousIndex, described below. */
66 ListView {67 Flickables.ListView {
67 id: listView68 id: listView
68 objectName: "listView"69 objectName: "listView"
6970
@@ -135,8 +136,6 @@
135136
136 boundsBehavior: Flickable.DragOverBounds137 boundsBehavior: Flickable.DragOverBounds
137 cacheBuffer: carousel.cacheBuffer138 cacheBuffer: carousel.cacheBuffer
138 flickDeceleration: Math.max(1500 * Math.pow(realWidth / referenceWidth, 1.5), 1500) // 1500 is platform default
139 maximumFlickVelocity: Math.max(2500 * Math.pow(realWidth / referenceWidth, 1.5), 2500) // 2500 is platform default
140 orientation: ListView.Horizontal139 orientation: ListView.Horizontal
141140
142 function getXFromContinuousIndex(index) {141 function getXFromContinuousIndex(index) {
143142
=== added directory 'qml/Components/Flickables'
=== added file 'qml/Components/Flickables/Flickable.qml'
--- qml/Components/Flickables/Flickable.qml 1970-01-01 00:00:00 +0000
+++ qml/Components/Flickables/Flickable.qml 2014-10-10 11:46:46 +0000
@@ -0,0 +1,23 @@
1/*
2 * Copyright (C) 2014 Canonical, Ltd.
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License as published by
6 * the Free Software Foundation; version 3.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU General Public License for more details.
12 *
13 * You should have received a copy of the GNU General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */
16
17import QtQuick 2.3 as QtQuick
18import Ubuntu.Components 1.1
19
20QtQuick.Flickable {
21 flickDeceleration: 1500 * units.gridUnit / 8
22 maximumFlickVelocity: 2500 * units.gridUnit / 8
23}
024
=== added file 'qml/Components/Flickables/GridView.qml'
--- qml/Components/Flickables/GridView.qml 1970-01-01 00:00:00 +0000
+++ qml/Components/Flickables/GridView.qml 2014-10-10 11:46:46 +0000
@@ -0,0 +1,25 @@
1/*
2 * Copyright (C) 2014 Canonical, Ltd.
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License as published by
6 * the Free Software Foundation; version 3.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU General Public License for more details.
12 *
13 * You should have received a copy of the GNU General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */
16
17import QtQuick 2.3 as QtQuick
18import Ubuntu.Components 1.1
19
20QtQuick.GridView {
21 // Attached components and usages like GridView.onRemove are known not to work
22 // please use GridView directly from QtQuick if needed
23 flickDeceleration: 1500 * units.gridUnit / 8
24 maximumFlickVelocity: 2500 * units.gridUnit / 8
25}
026
=== added file 'qml/Components/Flickables/ListView.qml'
--- qml/Components/Flickables/ListView.qml 1970-01-01 00:00:00 +0000
+++ qml/Components/Flickables/ListView.qml 2014-10-10 11:46:46 +0000
@@ -0,0 +1,25 @@
1/*
2 * Copyright (C) 2014 Canonical, Ltd.
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License as published by
6 * the Free Software Foundation; version 3.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU General Public License for more details.
12 *
13 * You should have received a copy of the GNU General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */
16
17import QtQuick 2.3 as QtQuick
18import Ubuntu.Components 1.1
19
20QtQuick.ListView {
21 // Attached components and usages like ListView.onRemove are known not to work
22 // please use ListView directly from QtQuick if needed
23 flickDeceleration: 1500 * units.gridUnit / 8
24 maximumFlickVelocity: 2500 * units.gridUnit / 8
25}
026
=== added file 'qml/Components/Flickables/ListViewWithPageHeader.qml'
--- qml/Components/Flickables/ListViewWithPageHeader.qml 1970-01-01 00:00:00 +0000
+++ qml/Components/Flickables/ListViewWithPageHeader.qml 2014-10-10 11:46:46 +0000
@@ -0,0 +1,23 @@
1/*
2 * Copyright (C) 2014 Canonical, Ltd.
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License as published by
6 * the Free Software Foundation; version 3.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU General Public License for more details.
12 *
13 * You should have received a copy of the GNU General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */
16
17import Dash 0.1
18import Ubuntu.Components 1.1
19
20ListViewWithPageHeader {
21 flickDeceleration: 1500 * units.gridUnit / 8
22 maximumFlickVelocity: 2500 * units.gridUnit / 8
23}
024
=== modified file 'qml/Components/ResponsiveGridView.qml'
--- qml/Components/ResponsiveGridView.qml 2014-09-19 10:31:14 +0000
+++ qml/Components/ResponsiveGridView.qml 2014-10-10 11:46:46 +0000
@@ -16,6 +16,7 @@
1616
17import QtQuick 2.317import QtQuick 2.3
18import Ubuntu.Components 0.118import Ubuntu.Components 0.1
19import "Flickables" as Flickables
1920
20/*21/*
21 Essentially a GridView where you can specify the maximum number of columns it can have.22 Essentially a GridView where you can specify the maximum number of columns it can have.
@@ -55,7 +56,7 @@
55 return rows * height56 return rows * height
56 }57 }
5758
58 GridView {59 Flickables.GridView {
59 id: gridView60 id: gridView
60 objectName: "responsiveGridViewGrid"61 objectName: "responsiveGridViewGrid"
61 anchors {62 anchors {
6263
=== modified file 'qml/Components/ZoomableImage.qml'
--- qml/Components/ZoomableImage.qml 2014-04-30 13:51:11 +0000
+++ qml/Components/ZoomableImage.qml 2014-10-10 11:46:46 +0000
@@ -16,7 +16,7 @@
1616
17import QtQuick 2.017import QtQuick 2.0
18import Ubuntu.Components 0.118import Ubuntu.Components 0.1
19import "../Components"19import "Flickables" as Flickables
2020
21/*! \brief Zoomable for image.21/*! \brief Zoomable for image.
2222
@@ -32,7 +32,7 @@
32 property alias scaleTo: lazyImage.scaleTo32 property alias scaleTo: lazyImage.scaleTo
33 property alias asynchronous: lazyImage.asynchronous33 property alias asynchronous: lazyImage.asynchronous
3434
35 Flickable {35 Flickables.Flickable {
36 id: flickable36 id: flickable
37 objectName: "flickable"37 objectName: "flickable"
38 clip: true38 clip: true
3939
=== modified file 'qml/Dash/CardHorizontalList.qml'
--- qml/Dash/CardHorizontalList.qml 2014-09-30 09:23:23 +0000
+++ qml/Dash/CardHorizontalList.qml 2014-10-10 11:46:46 +0000
@@ -17,6 +17,7 @@
17import QtQuick 2.217import QtQuick 2.2
18import Ubuntu.Components 1.118import Ubuntu.Components 1.1
19import "../Components"19import "../Components"
20import "../Components/Flickables" as Flickables
2021
21DashRenderer {22DashRenderer {
22 id: root23 id: root
@@ -25,7 +26,7 @@
25 collapsedHeight: expandedHeight26 collapsedHeight: expandedHeight
26 clip: true27 clip: true
2728
28 ListView {29 Flickables.ListView {
29 id: listView30 id: listView
30 anchors {31 anchors {
31 fill: parent32 fill: parent
3233
=== modified file 'qml/Dash/DashContent.qml'
--- qml/Dash/DashContent.qml 2014-09-22 14:24:34 +0000
+++ qml/Dash/DashContent.qml 2014-10-10 11:46:46 +0000
@@ -19,6 +19,7 @@
19import Unity 0.219import Unity 0.2
20import Utils 0.120import Utils 0.1
21import "../Components"21import "../Components"
22import "../Components/Flickables" as Flickables
2223
23Item {24Item {
24 id: dashContent25 id: dashContent
@@ -97,7 +98,7 @@
97 anchors.fill: parent98 anchors.fill: parent
98 }99 }
99100
100 ListView {101 Flickables.ListView {
101 id: dashContentList102 id: dashContentList
102 objectName: "dashContentList"103 objectName: "dashContentList"
103104
@@ -105,8 +106,6 @@
105 anchors.fill: parent106 anchors.fill: parent
106 orientation: ListView.Horizontal107 orientation: ListView.Horizontal
107 boundsBehavior: Flickable.DragAndOvershootBounds108 boundsBehavior: Flickable.DragAndOvershootBounds
108 flickDeceleration: units.gu(625)
109 maximumFlickVelocity: width * 5
110 snapMode: ListView.SnapOneItem109 snapMode: ListView.SnapOneItem
111 highlightMoveDuration: 250110 highlightMoveDuration: 250
112 highlightRangeMode: ListView.StrictlyEnforceRange111 highlightRangeMode: ListView.StrictlyEnforceRange
113112
=== modified file 'qml/Dash/DashNavigationButton.qml'
--- qml/Dash/DashNavigationButton.qml 2014-08-29 07:59:08 +0000
+++ qml/Dash/DashNavigationButton.qml 2014-10-10 11:46:46 +0000
@@ -16,6 +16,7 @@
1616
17import QtQuick 2.217import QtQuick 2.2
18import Ubuntu.Components 1.118import Ubuntu.Components 1.1
19import "../Components/Flickables" as Flickables
1920
20AbstractButton {21AbstractButton {
21 id: root22 id: root
@@ -75,7 +76,7 @@
75 }76 }
7677
77 // navigationListView is outside root78 // navigationListView is outside root
78 ListView {79 Flickables.ListView {
79 id: navigationListView80 id: navigationListView
80 objectName: "navigationListView"81 objectName: "navigationListView"
81 visible: height > 082 visible: height > 0
8283
=== modified file 'qml/Dash/DashNavigationList.qml'
--- qml/Dash/DashNavigationList.qml 2014-08-27 10:25:47 +0000
+++ qml/Dash/DashNavigationList.qml 2014-10-10 11:46:46 +0000
@@ -17,6 +17,7 @@
17import QtQuick 2.217import QtQuick 2.2
18import Ubuntu.Components 1.118import Ubuntu.Components 1.1
19import "../Components"19import "../Components"
20import "../Components/Flickables" as Flickables
2021
21Item {22Item {
22 id: root23 id: root
@@ -45,7 +46,7 @@
45 }46 }
46 }47 }
4748
48 Flickable {49 Flickables.Flickable {
49 id: flickable50 id: flickable
5051
51 anchors.fill: parent52 anchors.fill: parent
5253
=== modified file 'qml/Dash/PageHeader.qml'
--- qml/Dash/PageHeader.qml 2014-09-18 21:25:41 +0000
+++ qml/Dash/PageHeader.qml 2014-10-10 11:46:46 +0000
@@ -21,6 +21,7 @@
21import Ubuntu.Components.ListItems 1.021import Ubuntu.Components.ListItems 1.0
22import "../Components"22import "../Components"
23import "../Components/SearchHistoryModel"23import "../Components/SearchHistoryModel"
24import "../Components/Flickables" as Flickables
2425
25Item {26Item {
26 id: root27 id: root
@@ -127,7 +128,7 @@
127 }128 }
128 }129 }
129130
130 Flickable {131 Flickables.Flickable {
131 id: headerContainer132 id: headerContainer
132 objectName: "headerContainer"133 objectName: "headerContainer"
133 clip: contentY < height134 clip: contentY < height
134135
=== modified file 'qml/Dash/PreviewListView.qml'
--- qml/Dash/PreviewListView.qml 2014-09-18 05:05:56 +0000
+++ qml/Dash/PreviewListView.qml 2014-10-10 11:46:46 +0000
@@ -18,6 +18,7 @@
18import Ubuntu.Components 0.118import Ubuntu.Components 0.1
19import Unity 0.219import Unity 0.2
20import "../Components"20import "../Components"
21import "../Components/Flickables" as Flickables
21import "Previews" as Previews22import "Previews" as Previews
2223
23Item {24Item {
@@ -52,7 +53,7 @@
52 onBackClicked: root.backClicked()53 onBackClicked: root.backClicked()
53 }54 }
5455
55 ListView {56 Flickables.ListView {
56 id: previewListView57 id: previewListView
57 objectName: "listView"58 objectName: "listView"
58 anchors {59 anchors {
@@ -66,8 +67,6 @@
66 snapMode: ListView.SnapOneItem67 snapMode: ListView.SnapOneItem
67 boundsBehavior: Flickable.DragAndOvershootBounds68 boundsBehavior: Flickable.DragAndOvershootBounds
68 highlightMoveDuration: 25069 highlightMoveDuration: 250
69 flickDeceleration: units.gu(625)
70 maximumFlickVelocity: width * 5
71 cacheBuffer: 070 cacheBuffer: 0
7271
73 property bool open: false72 property bool open: false
7473
=== modified file 'qml/Dash/Previews/Preview.qml'
--- qml/Dash/Previews/Preview.qml 2014-08-11 18:32:23 +0000
+++ qml/Dash/Previews/Preview.qml 2014-10-10 11:46:46 +0000
@@ -16,6 +16,7 @@
1616
17import QtQuick 2.017import QtQuick 2.0
18import Ubuntu.Components 0.118import Ubuntu.Components 0.1
19import "../../Components/Flickables" as Flickables
1920
20/*! \brief This component constructs the Preview UI.21/*! \brief This component constructs the Preview UI.
21 *22 *
@@ -63,7 +64,7 @@
63 Repeater {64 Repeater {
64 model: previewModel65 model: previewModel
6566
66 delegate: ListView {67 delegate: Flickables.ListView {
67 id: column68 id: column
68 anchors { top: parent.top; bottom: parent.bottom }69 anchors { top: parent.top; bottom: parent.bottom }
69 width: row.columnWidth70 width: row.columnWidth
7071
=== modified file 'qml/Dash/Previews/PreviewImageGallery.qml'
--- qml/Dash/Previews/PreviewImageGallery.qml 2014-09-30 08:12:23 +0000
+++ qml/Dash/Previews/PreviewImageGallery.qml 2014-10-10 11:46:46 +0000
@@ -17,6 +17,7 @@
17import QtQuick 2.017import QtQuick 2.0
18import Ubuntu.Components 1.118import Ubuntu.Components 1.1
19import "../../Components"19import "../../Components"
20import "../../Components/Flickables" as Flickables
2021
21/*! This preview widget shows a horizontal list of images.22/*! This preview widget shows a horizontal list of images.
22 * The URIs for the images should be an array in widgetData["sources"].23 * The URIs for the images should be an array in widgetData["sources"].
@@ -28,7 +29,7 @@
2829
29 property Item rootItem: QuickUtils.rootItem(root)30 property Item rootItem: QuickUtils.rootItem(root)
3031
31 ListView {32 Flickables.ListView {
32 id: previewImageListView33 id: previewImageListView
33 objectName: "previewImageListView"34 objectName: "previewImageListView"
34 spacing: units.gu(1)35 spacing: units.gu(1)
@@ -102,7 +103,7 @@
102 UbuntuNumberAnimation { duration: UbuntuAnimation.FastDuration }103 UbuntuNumberAnimation { duration: UbuntuAnimation.FastDuration }
103 }104 }
104105
105 ListView {106 Flickables.ListView {
106 id: slideShowListView107 id: slideShowListView
107 objectName: "slideShowListView"108 objectName: "slideShowListView"
108 anchors.fill: parent109 anchors.fill: parent
109110
=== modified file 'qml/Dash/ScopeListView.qml'
--- qml/Dash/ScopeListView.qml 2014-08-26 09:44:35 +0000
+++ qml/Dash/ScopeListView.qml 2014-10-10 11:46:46 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 * Copyright (C) 2013 Canonical, Ltd.2 * Copyright (C) 2014 Canonical, Ltd.
3 *3 *
4 * This program is free software; you can redistribute it and/or modify4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License as published by5 * it under the terms of the GNU General Public License as published by
@@ -14,11 +14,8 @@
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */15 */
1616
17import QtQuick 2.017import "../Components/Flickables" as Flickables
18import Dash 0.1
1918
20ListViewWithPageHeader {19Flickables.ListViewWithPageHeader {
21 maximumFlickVelocity: height * 10
22 flickDeceleration: height * 2
23 cacheBuffer: Number.MAX_VALUE20 cacheBuffer: Number.MAX_VALUE
24}21}
2522
=== modified file 'qml/Dash/ScopeSettingsPage.qml'
--- qml/Dash/ScopeSettingsPage.qml 2014-09-30 15:02:23 +0000
+++ qml/Dash/ScopeSettingsPage.qml 2014-10-10 11:46:46 +0000
@@ -18,6 +18,7 @@
18import Ubuntu.Components 1.118import Ubuntu.Components 1.1
19import Unity 0.219import Unity 0.2
20import "../Components"20import "../Components"
21import "../Components/Flickables" as Flickables
21import "ScopeSettings"22import "ScopeSettings"
2223
23Item {24Item {
@@ -39,7 +40,7 @@
39 onBackClicked: root.backClicked()40 onBackClicked: root.backClicked()
40 }41 }
4142
42 ListView {43 Flickables.ListView {
43 id: scopeSettings44 id: scopeSettings
44 objectName: "scopeSettings"45 objectName: "scopeSettings"
45 anchors {46 anchors {
4647
=== modified file 'qml/Dash/ScopesOverviewAll.qml'
--- qml/Dash/ScopesOverviewAll.qml 2014-09-19 10:36:07 +0000
+++ qml/Dash/ScopesOverviewAll.qml 2014-10-10 11:46:46 +0000
@@ -16,8 +16,9 @@
1616
17import QtQuick 2.017import QtQuick 2.0
18import Ubuntu.Components 0.118import Ubuntu.Components 0.1
19import "../Components/Flickables" as Flickables
1920
20Flickable {21Flickables.Flickable {
21 id: root22 id: root
2223
23 property alias model: cardGrid.model24 property alias model: cardGrid.model
2425
=== modified file 'qml/Dash/ScopesOverviewFavorites.qml'
--- qml/Dash/ScopesOverviewFavorites.qml 2014-09-04 16:54:15 +0000
+++ qml/Dash/ScopesOverviewFavorites.qml 2014-10-10 11:46:46 +0000
@@ -14,9 +14,11 @@
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */15 */
1616
17import QtQuick 2.017import QtQuick 2.3
18import Ubuntu.Components 1.1
19import "../Components/Flickables" as Flickables
1820
19Flickable {21Flickables.Flickable {
20 id: root22 id: root
2123
22 signal clicked(int index, var result, var itemModel)24 signal clicked(int index, var result, var itemModel)
2325
=== modified file 'qml/Greeter/LoginList.qml'
--- qml/Greeter/LoginList.qml 2014-10-08 19:17:28 +0000
+++ qml/Greeter/LoginList.qml 2014-10-10 11:46:46 +0000
@@ -18,6 +18,7 @@
18import Ubuntu.Components 0.118import Ubuntu.Components 0.1
19import LightDM 0.1 as LightDM19import LightDM 0.1 as LightDM
20import "../Components"20import "../Components"
21import "../Components/Flickables" as Flickables
2122
22Item {23Item {
23 id: root24 id: root
@@ -68,7 +69,7 @@
68 antialiasing: true69 antialiasing: true
69 }70 }
7071
71 ListView {72 Flickables.ListView {
72 id: userList73 id: userList
73 objectName: "userList"74 objectName: "userList"
7475
@@ -78,7 +79,6 @@
78 preferredHighlightEnd: userList.height / 2 - root.highlightedHeight / 279 preferredHighlightEnd: userList.height / 2 - root.highlightedHeight / 2
79 highlightRangeMode: ListView.StrictlyEnforceRange80 highlightRangeMode: ListView.StrictlyEnforceRange
80 highlightMoveDuration: root.moveDuration81 highlightMoveDuration: root.moveDuration
81 flickDeceleration: 10000
8282
83 readonly property bool movingInternally: moveTimer.running || userList.moving83 readonly property bool movingInternally: moveTimer.running || userList.moving
8484
8585
=== modified file 'qml/Hud/Hud.qml'
--- qml/Hud/Hud.qml 2014-06-11 15:36:51 +0000
+++ qml/Hud/Hud.qml 2014-10-10 11:46:46 +0000
@@ -19,6 +19,7 @@
19import HudClient 0.119import HudClient 0.1
2020
21import "../Components"21import "../Components"
22import "../Components/Flickables" as Flickables
2223
23Item {24Item {
24 id: hud25 id: hud
@@ -400,7 +401,7 @@
400 }401 }
401 progress: MathUtils.clamp((y - hudShowable.y + height - units.gu(8))/elementsYSliding, 0, 1)402 progress: MathUtils.clamp((y - hudShowable.y + height - units.gu(8))/elementsYSliding, 0, 1)
402403
403 Flickable {404 Flickables.Flickable {
404 anchors.left: parent.left405 anchors.left: parent.left
405 anchors.right: parent.right406 anchors.right: parent.right
406 contentHeight: resultList.height407 contentHeight: resultList.height
407408
=== modified file 'qml/Hud/HudParametrizedActionsPage.qml'
--- qml/Hud/HudParametrizedActionsPage.qml 2014-08-13 11:56:16 +0000
+++ qml/Hud/HudParametrizedActionsPage.qml 2014-10-10 11:46:46 +0000
@@ -18,6 +18,7 @@
18import Ubuntu.Components 1.118import Ubuntu.Components 1.1
19import Ubuntu.Components.Themes.Ambiance 1.119import Ubuntu.Components.Themes.Ambiance 1.1
20import "../Components"20import "../Components"
21import "../Components/Flickables" as Flickables
2122
22Item {23Item {
23 property alias header: header.title24 property alias header: header.title
@@ -74,7 +75,7 @@
74 return values75 return values
75 }76 }
7677
77 Flickable {78 Flickables.Flickable {
78 anchors.top: parent.top79 anchors.top: parent.top
79 anchors.bottom: buttons.top80 anchors.bottom: buttons.top
80 anchors.left: parent.left81 anchors.left: parent.left
8182
=== modified file 'qml/Launcher/LauncherPanel.qml'
--- qml/Launcher/LauncherPanel.qml 2014-10-07 08:25:59 +0000
+++ qml/Launcher/LauncherPanel.qml 2014-10-10 11:46:46 +0000
@@ -21,6 +21,7 @@
21import Ubuntu.Components.Popups 0.121import Ubuntu.Components.Popups 0.1
22import "../Components/ListItems"22import "../Components/ListItems"
23import "../Components/"23import "../Components/"
24import "../Components/Flickables" as Flickables
2425
25Rectangle {26Rectangle {
26 id: root27 id: root
@@ -74,7 +75,7 @@
74 anchors.fill: parent75 anchors.fill: parent
75 clip: true76 clip: true
7677
77 ListView {78 Flickables.ListView {
78 id: launcherListView79 id: launcherListView
79 objectName: "launcherListView"80 objectName: "launcherListView"
80 anchors {81 anchors {
8182
=== modified file 'qml/Notifications/Notification.qml'
--- qml/Notifications/Notification.qml 2014-09-18 21:25:00 +0000
+++ qml/Notifications/Notification.qml 2014-10-10 11:46:46 +0000
@@ -20,6 +20,7 @@
20import Unity.Notifications 1.020import Unity.Notifications 1.0
21import QMenuModel 0.121import QMenuModel 0.1
22import Utils 0.122import Utils 0.1
23import "../Components/Flickables" as Flickables
2324
24import Ubuntu.Components.ListItems 0.1 as ListItem25import Ubuntu.Components.ListItems 0.1 as ListItem
2526
@@ -455,7 +456,7 @@
455 onClicked: notification.notification.invokeAction(comboRepeater.itemAt(2).actionId)456 onClicked: notification.notification.invokeAction(comboRepeater.itemAt(2).actionId)
456 expanded: false457 expanded: false
457 expandedHeight: (comboRepeater.count - 2) * units.gu(4) + units.gu(.5)458 expandedHeight: (comboRepeater.count - 2) * units.gu(4) + units.gu(.5)
458 comboList: Flickable {459 comboList: Flickables.Flickable {
459 // this has to be wrapped inside a flickable460 // this has to be wrapped inside a flickable
460 // to work around a feature/bug? of the461 // to work around a feature/bug? of the
461 // ComboButton SDK-element, making a regular462 // ComboButton SDK-element, making a regular
462463
=== modified file 'qml/Notifications/Notifications.qml'
--- qml/Notifications/Notifications.qml 2014-08-25 11:31:05 +0000
+++ qml/Notifications/Notifications.qml 2014-10-10 11:46:46 +0000
@@ -19,8 +19,9 @@
19import Unity.Notifications 1.0 as UnityNotifications19import Unity.Notifications 1.0 as UnityNotifications
20import Utils 0.120import Utils 0.1
21import "../Components"21import "../Components"
22import "../Components/Flickables" as Flickables
2223
23ListView {24Flickables.ListView {
24 id: notificationList25 id: notificationList
2526
26 objectName: "notificationList"27 objectName: "notificationList"
2728
=== modified file 'qml/Panel/IndicatorRow.qml'
--- qml/Panel/IndicatorRow.qml 2014-05-07 13:59:58 +0000
+++ qml/Panel/IndicatorRow.qml 2014-10-10 11:46:46 +0000
@@ -18,6 +18,7 @@
18import Ubuntu.Components 0.118import Ubuntu.Components 0.1
19import Unity.Indicators 0.1 as Indicators19import Unity.Indicators 0.1 as Indicators
20import "../Components"20import "../Components"
21import "../Components/Flickables" as Flickables
2122
22Item {23Item {
23 id: indicatorRow24 id: indicatorRow
@@ -60,7 +61,7 @@
60 }61 }
61 }62 }
6263
63 ListView {64 Flickables.ListView {
64 id: itemView65 id: itemView
65 objectName: "indicatorRowItems"66 objectName: "indicatorRowItems"
66 interactive: false67 interactive: false
6768
=== modified file 'qml/Panel/Indicators/DefaultIndicatorPage.qml'
--- qml/Panel/Indicators/DefaultIndicatorPage.qml 2014-09-29 10:24:58 +0000
+++ qml/Panel/Indicators/DefaultIndicatorPage.qml 2014-10-10 11:46:46 +0000
@@ -21,6 +21,7 @@
21import QtQuick 2.021import QtQuick 2.0
22import Ubuntu.Components 0.1 as Components22import Ubuntu.Components 0.1 as Components
23import Unity.Indicators 0.1 as Indicators23import Unity.Indicators 0.1 as Indicators
24import "../../Components/Flickables" as Flickables
2425
25IndicatorBase {26IndicatorBase {
26 id: main27 id: main
@@ -65,7 +66,7 @@
65 }66 }
66 }67 }
6768
68 ListView {69 Flickables.ListView {
69 id: mainMenu70 id: mainMenu
70 objectName: "mainMenu"71 objectName: "mainMenu"
71 model: menuStack.rootMenu72 model: menuStack.rootMenu
7273
=== modified file 'qml/Panel/Indicators/client/IndicatorsList.qml'
--- qml/Panel/Indicators/client/IndicatorsList.qml 2014-01-30 14:54:01 +0000
+++ qml/Panel/Indicators/client/IndicatorsList.qml 2014-10-10 11:46:46 +0000
@@ -22,6 +22,7 @@
22import Ubuntu.Components.ListItems 0.1 as ListItem22import Ubuntu.Components.ListItems 0.1 as ListItem
23import Unity.Indicators 0.1 as Indicators23import Unity.Indicators 0.1 as Indicators
24import "../.."24import "../.."
25import "../../../Components/Flickables" as Flickables
2526
26Page {27Page {
27 id: page28 id: page
@@ -35,7 +36,7 @@
35 Component.onCompleted: load(profile)36 Component.onCompleted: load(profile)
36 }37 }
3738
38 ListView {39 Flickables.ListView {
39 id: mainMenu40 id: mainMenu
40 objectName: "mainMenu"41 objectName: "mainMenu"
41 anchors.fill: parent42 anchors.fill: parent
4243
=== modified file 'qml/Panel/Indicators/client/IndicatorsTree.qml'
--- qml/Panel/Indicators/client/IndicatorsTree.qml 2013-11-24 02:23:56 +0000
+++ qml/Panel/Indicators/client/IndicatorsTree.qml 2014-10-10 11:46:46 +0000
@@ -22,6 +22,7 @@
22import Unity.Indicators 0.1 as Indicators22import Unity.Indicators 0.1 as Indicators
23import QMenuModel 0.123import QMenuModel 0.1
24import Ubuntu.Components.ListItems 0.1 as ListItem24import Ubuntu.Components.ListItems 0.1 as ListItem
25import "../../../Components/Flickables" as Flickables
2526
26Page {27Page {
27 id: page28 id: page
@@ -52,7 +53,7 @@
52 model: unityModel53 model: unityModel
53 }54 }
5455
55 Flickable {56 Flickables.Flickable {
56 anchors.fill: parent57 anchors.fill: parent
57 contentHeight: all_data.height58 contentHeight: all_data.height
58 clip:true59 clip:true
5960
=== modified file 'qml/Panel/MenuContent.qml'
--- qml/Panel/MenuContent.qml 2014-09-29 10:24:58 +0000
+++ qml/Panel/MenuContent.qml 2014-10-10 11:46:46 +0000
@@ -20,6 +20,7 @@
20import Unity.Indicators 0.1 as Indicators20import Unity.Indicators 0.1 as Indicators
21import Utils 0.121import Utils 0.1
22import "../Components"22import "../Components"
23import "../Components/Flickables" as Flickables
23import "Indicators"24import "Indicators"
2425
25Rectangle {26Rectangle {
@@ -39,7 +40,7 @@
39 listViewHeader.currentIndex = index;40 listViewHeader.currentIndex = index;
40 }41 }
4142
42 ListView {43 Flickables.ListView {
43 id: listViewHeader44 id: listViewHeader
44 objectName: "indicatorsHeaderListView"45 objectName: "indicatorsHeaderListView"
45 model: content.indicatorsModel46 model: content.indicatorsModel
@@ -80,7 +81,7 @@
80 }81 }
81 }82 }
8283
83 ListView {84 Flickables.ListView {
84 id: listViewContent85 id: listViewContent
85 objectName: "indicatorsContentListView"86 objectName: "indicatorsContentListView"
86 anchors {87 anchors {
8788
=== modified file 'qml/Stages/PhoneStage.qml'
--- qml/Stages/PhoneStage.qml 2014-10-07 18:18:44 +0000
+++ qml/Stages/PhoneStage.qml 2014-10-10 11:46:46 +0000
@@ -21,6 +21,7 @@
21import Unity.Session 0.121import Unity.Session 0.1
22import Utils 0.122import Utils 0.1
23import "../Components"23import "../Components"
24import "../Components/Flickables" as Flickables
2425
25Rectangle {26Rectangle {
26 id: root27 id: root
@@ -120,7 +121,7 @@
120121
121 }122 }
122123
123 Flickable {124 Flickables.Flickable {
124 id: spreadView125 id: spreadView
125 objectName: "spreadView"126 objectName: "spreadView"
126 anchors.fill: parent127 anchors.fill: parent
127128
=== modified file 'qml/Stages/TabletStage.qml'
--- qml/Stages/TabletStage.qml 2014-10-07 18:39:38 +0000
+++ qml/Stages/TabletStage.qml 2014-10-10 11:46:46 +0000
@@ -20,6 +20,7 @@
20import Unity.Application 0.120import Unity.Application 0.1
21import Utils 0.121import Utils 0.1
22import "../Components"22import "../Components"
23import "../Components/Flickables" as Flickables
2324
24Rectangle {25Rectangle {
25 id: root26 id: root
@@ -153,7 +154,7 @@
153 }154 }
154 }155 }
155156
156 Flickable {157 Flickables.Flickable {
157 id: spreadView158 id: spreadView
158 anchors.fill: parent159 anchors.fill: parent
159 interactive: (spreadDragArea.status == DirectionalDragArea.Recognized || phase > 1)160 interactive: (spreadDragArea.status == DirectionalDragArea.Recognized || phase > 1)

Subscribers

People subscribed via source and target branches