Ubuntu
ifupdown package

network-interface-security.conf needs to go away when the interface does.

Bug #1065684 reported by Serge Hallyn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ifupdown (Ubuntu)
Fix Released
Medium
Stéphane Graber

Bug Description

The network-interface-security upstart job should be a task. It doesn't do anything after the pre-start script, and there is no stop on. On a machine which creates (and destroys) a lot of interfaces, this can result in thousands of network-interface-security jobs for non-existent nics.

THis is related to bug 1065589.

Revision history for this message
Kees Cook (kees) wrote :

No so simple, unfortunately. Here's why it was written this way:

# In order to handle the lack of upstart feature LP: #568860, we need to
# run multiple times, for each of the above "starting" service instances, or
# else another one might run while we're running, and not wait for us to
# finish.
instance $JOB${INTERFACE:+/}${INTERFACE:-}

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks, I saw that comment before but bc I didn't go look at the bug itself I misunderstood it.

summary: - network-interface-security.conf should be a task
+ network-interface-security.conf needs to go away when the interface
+ does.
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Changed bug title to reflect what we really need out of it. Turning it into a task was just the obvious (but as Kees points out wrong) way to do it.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

@Kees,

is there any reason not to add a 'stop on net-device-removed INTERFACE=$INTERFACE' to this job?

Revision history for this message
Stéphane Graber (stgraber) wrote :

So I have a fix for this which in addition to the uevent kernel fix for network devices moving to other netns should fix this bug entirely.

I'm testing the new kernel and upstart job now, should be uploaded soonish.

Changed in ifupdown (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ifupdown - 0.7.5ubuntu2

---------------
ifupdown (0.7.5ubuntu2) raring; urgency=low

  * Update network-interface-security job to stop when the parent job is
    stopped itself. This avoids leftover instances. (LP: #1065684)
  * Set mtu of tunnel devices. (LP: #1074048)
  * Actually set the new calculated value for duplicate entries. (LP: #1086517)
 -- Stephane Graber <email address hidden> Tue, 11 Dec 2012 19:53:56 -0500

Changed in ifupdown (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.