Please build git-annex with webapp enabled

Bug #1084693 reported by Greg Grossmeier
88
This bug affects 19 people
Affects Status Importance Assigned to Milestone
git-annex (Ubuntu)
Fix Released
Medium
Colin Watson
Raring
Fix Released
Medium
Iain Lane

Bug Description

[ Description ]

A packaging error, which only causes a problem on the buildds, caused the git annex webapp to not be built in Raring.

[ Fix ]

Fix the detection of Yesod to only look at strictly relevant fields of dpkg-query's output, to correctly enable the webapp when yesod is available.

[ Test ]

Before, see that `git annex webapp' gives an error.
After, see that it successfully starts the webapp.

[ Regression potential ]

This changes the flags passed to the build system to enable more features. Please give the application a good general workout to see whether this has any unfortunate interactions.

[ Original description ]

greg@x220:~/Music$ git-annex version
git-annex version: 3.20121017

greg@x220:~/Documents$ git-annex webapp
git-annex: unknown command webapp

Reported upstream as git-annex in Raring is just a sync from sid, where Joey Hess publishes his builds.

http://git-annex.branchable.com/bugs/git-annex_webapp_command_not_found/

It appears that git-annex on Ubuntu is not being built with webapp enabled.

Please enable it for Raring.

This is important as the webapp/assistant functionality from git-annex is going to be the most popular way that people find out about it due to the successful Kickstarter campaign from Joey: http://www.kickstarter.com/projects/joeyh/git-annex-assistant-like-dropbox-but-with-your-own/

Thanks.

Changed in git-annex (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Colin Watson (cjwatson) wrote :

I'm sorry about the confusion here. Last cycle git-annex got caught up in a very complex transition to GHC 7.6 and we only barely managed to keep it in the release at all; sadly I didn't notice this bug or I might have tried to fix it. We weren't explicitly disabling the webapp, and I can't quite work out why it vanished, but -DWITH_WEBAPP is indeed missing from the preprocessor flags ...

Anyway, I've uploaded 4.20130501ubuntu1 to saucy (it still needs a handful of control file modifications for GHC 7.6, which I'll forward if necessary once Debian gets that far) and my local build has the webapp enabled. I'll close this bug once I've checked that the official builds do too.

Changed in git-annex (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Colin Watson (cjwatson) wrote :

I've confirmed that the official build of 4.20130501ubuntu1 has the webapp enabled. It should be available in the saucy archive shortly.

Changed in git-annex (Ubuntu):
milestone: ubuntu-13.04 → none
status: In Progress → Fix Released
Revision history for this message
Marc Pilloud (marc.pilloud) wrote :

Please enable it for Raring. Thanks.

Revision history for this message
Colin Watson (cjwatson) wrote :

I'm not sure I'll have time to figure out why it went missing (since as I say we weren't intentionally disabling it), but if somebody wants to work it out then I would be happy to apply a patch.

Changed in git-annex (Ubuntu Raring):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Christoph Hipp (chi-g) wrote :

Please enable it for Raring. Thanks.

Revision history for this message
Colin Watson (cjwatson) wrote :

Christoph, it's not useful to simply repeat previous comments word-for-word. Please see my comment #4.

Revision history for this message
Christoph Hipp (chi-g) wrote :

Colin, ok. I'm sorry. I'd love to help you but I have no idea how... :-(

Christoph Hipp (chi-g)
Changed in git-annex (Ubuntu Raring):
status: Triaged → Fix Released
Revision history for this message
Christoph Hipp (chi-g) wrote :

I'm sorry, it looks like I changed the status to Fix Released (somehow).
Since I cannot undo it, can someone else please do it?
Sorry again.

Iain Lane (laney)
Changed in git-annex (Ubuntu Raring):
status: Fix Released → Triaged
Revision history for this message
Robin Sheat (eythian) wrote :

Is there a way we can manually activate the webapp?

Revision history for this message
Iain Lane (laney) wrote : Re: [Bug 1084693] Re: Please build git-annex with webapp enabled

On Mon, Jun 10, 2013 at 02:32:48AM -0000, Robin Sheat wrote:
> Is there a way we can manually activate the webapp?

For me, if I build the package myself the webapp is enabled.

Here's a paste of what I said on IRC; I found the reason the package
isn't getting the webapp enabled, but I don't know *why* this is
happening. I'd like to get a handle on this first.

,----
| 09/06 20:04:14 <Laney> hmm
| 09/06 20:04:32 <Laney> so I looked at why we didn't get the git-annex
| webapp on raring
| 09/06 20:05:32 <Laney>
| https://launchpadlibrarian.net/142026098/buildlog_ubuntu-raring-i386.git-annex_3.20121112ubuntu3+laney1_UPLOADING.txt.gz
| shows that the dpkg-query call to figure out if libghc-yesod-dev is
| installed returns "purge ok installed"
| 09/06 20:06:24 <Laney> which means that we use the 'else' branch which
| doesn't build the webapp
| 09/06 20:06:47 <Laney> but why does that happen? I get "install ok
| installed" locally.
`----

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Colin Watson (cjwatson) wrote :

The first field ("purge") is the desired state, mainly there for
dselect. Normally it would match up after an apt-get install, and I
agree it's weird that it doesn't here, but I'd be inclined to say that
we should just ignore that field and only worry about the third
("installed").

Revision history for this message
Iain Lane (laney) wrote :

On Mon, Jun 10, 2013 at 08:51:08AM -0000, Colin Watson wrote:
> The first field ("purge") is the desired state, mainly there for
> dselect. Normally it would match up after an apt-get install, and I
> agree it's weird that it doesn't here, but I'd be inclined to say that
> we should just ignore that field and only worry about the third
> ("installed").

Right, I know what it's for, but I didn't know if this is something that
the buildds are doing wrong (so a problem to be fixed there rather than
in packages, given that local sbuild behaves differently); seems curious
to me.

But it does seem right that packages should ignore the desired state and
only care about the current, indeed.

 affects ubuntu/raring/git-annex
 assignee laney
 status inprgress

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Iain Lane (laney)
Changed in git-annex (Ubuntu Raring):
status: Triaged → In Progress
Revision history for this message
Iain Lane (laney) wrote :

Uploaded to raring's queue for review.

Iain Lane (laney)
description: updated
Revision history for this message
Adam Conrad (adconrad) wrote :

FWIW, this isn't something the buildds are doing "wrong", though arguably "unnecessary" now that we don't purge packages at the end of builds.

sbuild always set the desired state of everything it installs to "purge", so it's a single call to remove them all again at the end.

Changed in git-annex (Ubuntu Raring):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Greg, or anyone else affected,

Accepted git-annex into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/git-annex/3.20121112ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Dave Lane (lightweight) wrote :

The package installs for me on Mint 15 (based on Raring 13.04) and git-annex assistant works as I would expect! Many thanks.

Iain Lane (laney)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Scott Kitterman (kitterman) wrote :

Verification needs to be done on Ubuntu, not a derivative.

tags: added: verification-needed
removed: verification-done
Revision history for this message
Greg Grossmeier (greg.grossmeier) wrote :

And this is about the git-annex webapp, not just the assistant. Sorry to be pedantic, but the "git-annex assistant" command wasn't the problem, it was "git-annex webapp". (The webapp depends on the assistant)

Revision history for this message
Iain Lane (laney) wrote : Re: [Bug 1084693] Re: Please build git-annex with webapp enabled

On Mon, Jun 17, 2013 at 10:22:04AM -0000, Scott Kitterman wrote:
> Verification needs to be done on Ubuntu, not a derivative.

I don't know why my earlier email didn't show up*. That was just a
coincidence. I self verified and don't know how to change tags via the
email interface so visited the bug to do that.

But since there are obviously people watching this, why doesn't someone
else do it too? :-)

* Oh, yes I do. I mangled To:.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Greg Grossmeier (greg.grossmeier) wrote :

Confirmed. git-annex webapp does what is expected (ie: start the webapp and sync files)

greg@xps:~/Downloads$ apt-cache policy git-annex
git-annex:
  Installed: 3.20121112ubuntu4
  Candidate: 3.20121112ubuntu4
  Version table:
 *** 3.20121112ubuntu4 0
        100 /var/lib/dpkg/status
(I downloaded the deb directly instead of enabling -proposed)

There are some oddities with git-annex (the webapp has some UI bugs: interface not responding, etc) but those should probably be another bug report.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package git-annex - 3.20121112ubuntu4

---------------
git-annex (3.20121112ubuntu4) raring; urgency=low

  * Check for the 'ok installed' substring in the dpkg-query output when
    determining whether Yesod is installed; this matches against the 'current'
    state, rather than the 'desired' and 'current' states that checking for
    'install ok installed' does. The latter is a problem on the buildds where
    the desired state is 'purge'. (LP: #1084693)
 -- Iain Lane <email address hidden> Mon, 10 Jun 2013 22:05:18 +0100

Changed in git-annex (Ubuntu Raring):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.