Need .desktop file

openmsx-catapult-0.9.1-0ubuntu1 has already a .desktop file (openmsx-catapult/desktop/openMSX-Catapult.desktop).
It has also a menu file in /debian. I don't know why it can't be found in Applications...

:-/ -right!? Hmm...

Here's the file:
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/saucy/openmsx-catapult/saucy/files/head:/desktop/

[Desktop Entry]
Encoding=UTF-8
Name=openMSX Catapult
Comment=Graphical interface for openMSX
Type=Application
Exec=%INSTALL_BASE%/bin/catapult
Icon=%INSTALL_BASE%/resources/icons/catapult.xpm
DocPath=%INSTALL_BASE%/doc/manual/index.html
Terminal=false
Categories=Application;Emulator;Game;

The source package may contain a .desktop file, but this file is not present in the binary package, at least for Ubuntu 12.04. The build rules seem to ignore the file, and it is not installed.

The '.menu' file, used in the Debian Menu spec, is ignored in Ubuntu, which uses the Freedesktop Desktop Entry and Menu Spec ( http://standards.freedesktop.org/desktop-entry-spec/latest/ ). File should be installed to /usr/share/applications.

Also, the .desktop file in the source package has some issues:
- 'DocPath' is not a recognized key (see http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html )
- 'Application' is not a valid category (see http://standards.freedesktop.org/menu-spec/1.0/apa.html )

The source package may contain a .desktop file, but this file is not present in the binary package, at least for Ubuntu 12.04. The build rules seem to ignore the file, and it is not installed.

The '.menu' file, used in the Debian Menu spec, is ignored in Ubuntu, which uses the Freedesktop Desktop Entry and Menu Spec ( http://standards.freedesktop.org/desktop-entry-spec/latest/ ). File should be installed to /usr/share/applications.

Also, the .desktop file in the source package has some issues:
- 'DocPath' is not a recognized key, it's valid for KDE only (see http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html )
- 'Application' is not a valid category (see http://standards.freedesktop.org/menu-spec/1.0/apa.html )
- 'Encoding' is a deprecated key (see http://standards.freedesktop.org/desktop-entry-spec/latest/apc.html )

seems that it doesn't work even in trusty with the latest package. investigating...

I forwarded the bug to debian, so the debian maintainer can fix it.
I also prepare a patch (a debdiff) for him, so he can easily incorporate the fix.
I attached the debdiff to this bug, so in the case he won't accept it someone (or even me if I'll remember) can upload it to ubuntu (after changing the relevant part in the changelog)

Since the Debian maintainer didn't reply, and doing an NMU for such minor issues is bad, here is a debdiff to be committed in Ubuntu.

Nice! Thanks for investigating and providing a patch!

Just a question: Does the icon and .desktop install need to be done "manually" (copying files) in rules? Isn't there a dh-something for that?

There is dh_install, but I need to rename the desktop file and the icon, and there is now way to do so otherwise.
I could use dh_installdirs to create the two directories instead of use mkdir -p in the rules file, but don't use it for 2 reasons: (1) I see a new file in the debian directory absurd for only 2 lines (2) it easier to ssee and understand the diff.
So I think it's pointless to use dh for this stuff.

Looking at the makefiles, there's actually a CATAPULT_NO_DESKTOP_HOOKS flag that is set to yes. So if you set that to no, the desktop file does get installed. Though it uses the lowres xmp icon, so we'd want to patch it anyways. So I went ahead and used your patch.

Thanks for your work on this!

This bug was fixed in the package openmsx-catapult - 0.10.0-1ubuntu1

---------------
openmsx-catapult (0.10.0-1ubuntu1) trusty; urgency=medium

  * Install a desktop file and a icon (LP: #1092091):
    + debian/rules: install the desktop file and the icon.
    + debian/patches/desktop_file: add to make the desktop file compliant with
      the installation.
    + debian/patches/series: updated.
 -- Mattia Rizzolo <email address hidden> Wed, 19 Feb 2014 16:34:14 +0100