[SRU] Crash when renumber current channel

Bug #1164457 reported by Triniton Adam
56
This bug affects 11 people
Affects Status Importance Assigned to Milestone
tvtime (Ubuntu)
Fix Released
Undecided
Pojar Geo
Raring
Fix Released
Undecided
Pojar Geo
Saucy
Fix Released
Undecided
Pojar Geo

Bug Description

[Impact]

When renumber channel, tvtime let me to introduce more digits than there are channels and if number of typed digits exceeds 5, tvtime crash.

[Test Case]

1. Open tvtime
2. Press tab key to open osd menu
3. Go to setup -> channel management -> renumber current channel
4. Renumber current channel to 10000 and press enter.

Actual results:

tvtime crash

Expected results:

tvtime prevent me to type more digits than there are channels:
e.g. if in stations list are 100 channels, tvtime prevent me to type more digits than 3

[Regression Potential]

none, look good and this changes is tested in PPA https://launchpad.net/~geoubuntu/+archive/test/+sourcepub/3225631/+listing-archive-extra and saucy.

[Other Info]

No need to forward to Debian and upstream, as this doesn't currently affect Debian and upstream version.

Pojar Geo (geoubuntu)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in tvtime (Ubuntu):
status: New → Confirmed
Pojar Geo (geoubuntu)
description: updated
Pojar Geo (geoubuntu)
Changed in tvtime (Ubuntu):
assignee: nobody → POJAR GEORGE (geoubuntu)
Revision history for this message
Pojar Geo (geoubuntu) wrote :

Thank you Triniton Adam for reporting this.

In video example:
I have station list with 90 channels . I renumber station 55 to 74. When digits count is 2 ( 7 and 4 ), tvtime automatically sending enter command to prevent to enter more then 2 digits. In this way I can't type more digits then stations exist.

Now this bug is fixed.

Best regards

Revision history for this message
Pojar Geo (geoubuntu) wrote :
Pojar Geo (geoubuntu)
Changed in tvtime (Ubuntu):
status: Confirmed → New
Revision history for this message
Triniton Adam (trinitonadam) wrote :

Thanks for fix
I installed tvtime 32 bit from your PPA: https://launchpad.net/~geoubuntu/+archive/test-ppa/+sourcepub/3084616/+listing-archive-extra, and confirm that bug is resolved.

Pojar Geo (geoubuntu)
description: updated
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in tvtime (Ubuntu):
status: New → Confirmed
Pojar Geo (geoubuntu)
tags: added: raring
Pojar Geo (geoubuntu)
Changed in tvtime (Ubuntu):
assignee: POJAR GEORGE (geoubuntu) → nobody
Pojar Geo (geoubuntu)
Changed in tvtime (Ubuntu):
assignee: nobody → POJAR GEO (geoubuntu)
Pojar Geo (geoubuntu)
description: updated
description: updated
summary: - crash when renumber current channel
+ Crash when renumber current channel
description: updated
Pojar Geo (geoubuntu)
description: updated
description: updated
description: updated
description: updated
Pojar Geo (geoubuntu)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tvtime - 1.0.2-10ubuntu6

---------------
tvtime (1.0.2-10ubuntu6) saucy; urgency=low

  * Modified debian/patches/tvtime-1.0.2-channel_list.patch: Prevent app to
    crash when try to renumber current channel by send an 'ENTER' command if we
    type more digits than there are channels. (LP: #1164457)
    - Deleted tvtime-1.0.2-key_event.patch as a result.
 -- POJAR GEORGE <email address hidden> Thu, 04 Apr 2013 09:32:25 +0000

Changed in tvtime (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Pojar Geo (geoubuntu) wrote :

debdiff for raring

description: updated
Pojar Geo (geoubuntu)
summary: - Crash when renumber current channel
+ [SRU] Crash when renumber current channel
Changed in tvtime (Ubuntu Raring):
status: New → Confirmed
Pojar Geo (geoubuntu)
Changed in tvtime (Ubuntu Raring):
assignee: nobody → POJAR GEO (geoubuntu)
Pojar Geo (geoubuntu)
description: updated
Revision history for this message
Majorgeek Quintus (majorgeekquintus) wrote :

Thanks for this fix. Hats off to the develpers.

Pojar Geo (geoubuntu)
Changed in tvtime (Ubuntu Raring):
status: Confirmed → In Progress
Pojar Geo (geoubuntu)
description: updated
Pojar Geo (geoubuntu)
Changed in tvtime (Ubuntu Raring):
status: In Progress → Confirmed
Revision history for this message
Brian Murray (brian-murray) wrote :

Uploaded to raring.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Triniton, or anyone else affected,

Accepted tvtime into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/tvtime/1.0.2-10ubuntu5.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in tvtime (Ubuntu Raring):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Triniton Adam (trinitonadam) wrote :

OK. Confirm that this bug is gone.
Thanks

tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tvtime - 1.0.2-10ubuntu5.1

---------------
tvtime (1.0.2-10ubuntu5.1) raring-proposed; urgency=low

  * Modified debian/patches/tvtime-1.0.2-channel_list.patch: Prevent app to
    crash when try to renumber current channel by send an 'ENTER' command if we
    type more digits than there are channels. (LP: #1164457)
    - Deleted tvtime-1.0.2-key_event.patch as a result.
 -- POJAR GEORGE <email address hidden> Thu, 30 May 2013 13:23:33 -0700

Changed in tvtime (Ubuntu Raring):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.