Mir

[regression] GLRenderer* unit tests have recently become noisy

Bug #1308905 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Low
Mir development team
Mir 0.1.9
mir (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

[regression] unit test: GLRendererSetupProcess has recently become noisy ...

[==========] Running 6 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 3 tests from GLRendererSetupProcess
[ RUN ] GLRendererSetupProcess.vertex_shader_compiler_failure_recovers_and_throws

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: glDeleteShader(1)
Stack trace:
[ OK ] GLRendererSetupProcess.vertex_shader_compiler_failure_recovers_and_throws (1 ms)
[ RUN ] GLRendererSetupProcess.fragment_shader_compiler_failure_recovers_and_throw

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: glDeleteShader(2)
Stack trace:

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: glDeleteShader(1)
Stack trace:
[ OK ] GLRendererSetupProcess.fragment_shader_compiler_failure_recovers_and_throw (0 ms)
[ RUN ] GLRendererSetupProcess.graphics_program_linker_failure_recovers_and_throw

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: glDeleteProgram(1)
Stack trace:

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: glDeleteShader(2)
Stack trace:

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: glDeleteShader(1)
Stack trace:
[ OK ] GLRendererSetupProcess.graphics_program_linker_failure_recovers_and_throw (0 ms)
[----------] 3 tests from GLRendererSetupProcess (1 ms total)

Related branches

lp:~vanvugt/mir/fix-1308905
Rejected for merging into lp:mir
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Alan Griffiths: Approve
Diff: 39 lines (+8/-0)
1 file modified
tests/unit-tests/compositor/test_gl_renderer.cpp (+8/-0)
lp:~kdub/mir/gl-program-creation-factory
Alberto Aguirre (community): Approve
Alexandros Frantzis (community): Approve
Robert Carr (community): Needs Information
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 1061 lines (+439/-216)
20 files modified
examples/demo-shell/demo_renderer.cpp (+4/-2)
examples/demo-shell/demo_renderer.h (+1/-1)
examples/demo-shell/demo_shell.cpp (+9/-2)
include/platform/mir/graphics/gl_program_factory.h (+50/-0)
include/server/mir/compositor/gl_renderer.h (+6/-3)
include/server/mir/default_server_configuration.h (+3/-0)
include/server/mir/graphics/gl_program.h (+4/-4)
src/server/compositor/CMakeLists.txt (+0/-1)
src/server/compositor/default_configuration.cpp (+2/-2)
src/server/compositor/gl_renderer.cpp (+16/-14)
src/server/compositor/gl_renderer_factory.cpp (+9/-4)
src/server/compositor/gl_renderer_factory.h (+6/-10)
src/server/graphics/CMakeLists.txt (+2/-0)
src/server/graphics/default_configuration.cpp (+11/-0)
src/server/graphics/gl_program.cpp (+8/-8)
src/server/graphics/program_factory.cpp (+32/-0)
src/server/graphics/program_factory.h (+47/-0)
tests/unit-tests/compositor/test_gl_renderer.cpp (+17/-165)
tests/unit-tests/graphics/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/test_program_factory.cpp (+211/-0)
lp:ubuntu/utopic/mir
Daniel van Vugt (vanvugt)
Changed in mir:
assignee: nobody → Daniel van Vugt (vanvugt)
Daniel van Vugt (vanvugt)
summary: - [regression] unit test: GLRendererSetupProcess has recently become noisy
+ [regression] GLRenderer unit tests have recently become noisy
Alan Griffiths (alan-griffiths)
summary: - [regression] GLRenderer unit tests have recently become noisy
+ [regression] GLRendererSetupProcess unit tests have recently become
+ noisy
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The existing description is more accurate as "GLRendererSetupProcess" did not exist until the regression occurred.

summary: - [regression] GLRendererSetupProcess unit tests have recently become
- noisy
+ [regression] GLRenderer* unit tests have recently become noisy
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also fixed by kdub's landings of last night before my targeted fix could get approved.

Changed in mir:
assignee: Daniel van Vugt (vanvugt) → Mir development team (mir-team)
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu):
assignee: nobody → Daniel van Vugt (vanvugt)
assignee: Daniel van Vugt (vanvugt) → nobody
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.1.9+14.10.20140430.1-0ubuntu1

---------------
mir (0.1.9+14.10.20140430.1-0ubuntu1) utopic; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.1.9 (https://launchpad.net/mir/+milestone/0.1.9)
    - mirclient ABI unchanged, still at 7. Clients do not need rebuilding.
    - mirserver ABI bumped to 19. Shells need rebuilding.
    - More libmirserver class changes and reorganization, including;
      . Moving things from shell:: to scene::
      . Rewriting/refactoring surface factories.
    - Added an id() to Renderable.
    - Scene/Renderer interfaces:
      . Scene is no longer responsible for its own iteration (no for_each
        any more). Instead you should iterate over the list returned by
        Scene::generate_renderable_list().
    - Bugs fixed:
      . Stale socket issue. (LP: #1285215)
      . Qt render gets blocked on EGLSwapBuffers. (LP: #1292306)
      . Lock order violated found in helgrind (potential deadlock).
        (LP: #1296544)
      . [regression] SwitchingBundle in framedropping mode can hang.
        (LP: #1306464)
      . [DPMS] Display backlight turns back on almost immediately after
        being turned off. (LP: #1231857)
      . Wrong frame is seen on wake up/resume/unlock. (LP: #1233564)
      . Nested platform is not testable (LP: #1299101)
      . [regression] mir_demo_server_shell crashes on display resume.
        (LP: #1308941)
      . Multi-threaded composition is actually mostly serialized by
        SurfaceStack::guard. (LP: #1234018)
      . Mirscreencast slows down compositing and makes it very jerky.
        (LP: #1280938)
      . Mirscreencast can cause clients to render faster than the screen
        refresh rate. (LP: #1294361)
      . Screen turns on when a new session/surface appears. (LP: #1297876)
      . mir-doc package is >56MB in size, expands to >100MB of files.
        (LP: #1304998)
      . [regression] Clang: 'mir::test::doubles::MockSurface::visible'
        hides overloaded virtual function [-Woverloaded-virtual].
        (LP: #1301135)
      . [regression] GLRenderer* unit tests have recently become noisy.
        (LP: #1308905)
      . FocusController::set_focus_to() no longer seems to raise a session
        to the top. (LP: #1302689)

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Wed, 30 Apr 2014 13:26:58 +0000

Changed in mir (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.