Ubuntu Push client takes no commandline arguments

Bug #1311600 reported by John Lenton
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Push Notifications
Fix Released
Undecided
Samuele Pedroni
ubuntu-push (Ubuntu)
Fix Released
Undecided
John Lenton
Trusty
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

 * Every time we need to test something, either for an SRU or CI or QA or etc., we need to tell the user to edit the configuration file. The json parser we use is rather pedantic and the client will fail to start if the file is non-conforming, so there's a lot of space to break things.

[Test Case]

 * In the test case in e.g. https://bugs.launchpad.net/ubuntu-push/+bug/1309432 there's a rather handwavy step “edit /etc/xdg/[...] (or copy it to ~phablet/.config/[...] and edit it there”.

 * /usr/lib/ubuntu-push-client/ubuntu-push-client takes no commandline arguments

After this fix, “/usr/lib/ubuntu-push-client/ubuntu-push-client -help” will be somewhat useful, and we can tell people to say e.g. “-addr 192.168.1.1:9090” without risking messing up their configuration.

[Regression Potential]

If for whatever reason (corruption, a bad edit, etc) there is "rubbish" after the upstart script that starts the push client, after the fix, it will fail instead.

John Lenton (chipaca)
Changed in ubuntu-push (Ubuntu):
status: New → Fix Committed
Changed in ubuntu-push:
assignee: nobody → John Lenton (chipaca)
Changed in ubuntu-push (Ubuntu):
assignee: nobody → John Lenton (chipaca)
status: Fix Committed → New
Changed in ubuntu-push:
status: New → Fix Committed
assignee: John Lenton (chipaca) → Samuele Pedroni (pedronis)
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello John, or anyone else affected,

Accepted ubuntu-push into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-push/0.2.1+14.04.20140423.1-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubuntu-push (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Samuele Pedroni (pedronis) wrote :

verified with ubuntu-push-client_0.2.1+14.04.20140423.1-0ubuntu1_amd64.deb,

-help shows help

-addr lets specifiy an address to connect to

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-push - 0.2.1+14.04.20140423.1-0ubuntu1

---------------
ubuntu-push (0.2.1+14.04.20140423.1-0ubuntu1) trusty; urgency=high

  [ Samuele Pedroni ]
  * gave the client the ability to get config from commandline
    ( => easier automated testing) (LP: #1311600)

  [ John Lenton ]
  * Ensure ubuntu-push-client is the only one running in the session.
    (LP: #1309432)
  * Remove supurious numbers in brackets in notifications. (LP: #1308145)
  * Check the server certificate and server name. (LP: #1297969)
  * Loop whoopsie_identifier_generate until it starts working. (LP: #1309237)
  * In the session: set a flag on connect, clear it on successfully
    replying to ping or broadcast messages, check it at the top of
    autoredial. Also track the last autoredial, and set the delay flag if
    autoredial is re-called too quickly. (LP: #1309231)
 -- Ubuntu daily release <email address hidden> Wed, 23 Apr 2014 11:54:00 +0000

Changed in ubuntu-push (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of the Stable Release Update for ubuntu-push has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-push - 0.2.1+14.04.20140423.1-0ubuntu1

---------------
ubuntu-push (0.2.1+14.04.20140423.1-0ubuntu1) trusty; urgency=high

  [ Samuele Pedroni ]
  * gave the client the ability to get config from commandline
    ( => easier automated testing) (LP: #1311600)

  [ John Lenton ]
  * Ensure ubuntu-push-client is the only one running in the session.
    (LP: #1309432)
  * Remove supurious numbers in brackets in notifications. (LP: #1308145)
  * Check the server certificate and server name. (LP: #1297969)
  * Loop whoopsie_identifier_generate until it starts working. (LP: #1309237)
  * In the session: set a flag on connect, clear it on successfully
    replying to ping or broadcast messages, check it at the top of
    autoredial. Also track the last autoredial, and set the delay flag if
    autoredial is re-called too quickly. (LP: #1309231)
 -- Ubuntu daily release <email address hidden> Wed, 23 Apr 2014 11:54:00 +0000

Changed in ubuntu-push (Ubuntu):
status: New → Fix Released
John Lenton (chipaca)
Changed in ubuntu-push:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.