lxsession should depend on lxsession-logout

Are you saying, you were unable to log out of your system?

-----Original Message-----
From: "Sworddragon" <email address hidden>
Sent: ‎2/‎18/‎2015 3:10 PM
To: "<email address hidden>" <email address hidden>
Subject: [Bug 1423326] [NEW] lxsession should depend on lxsession-logout

Public bug reported:

I'm using Ubuntu 15.04 dev with lxsession 0.5.1-1ubuntu1 and if I'm not
wrong lxsession depended on lxsession-logout which got now removed from
the dependency list. But removing this package resulted on my system
that the logout window doesn't appear anymore so maybe it should get a
dependency again.

** Affects: lxsession (Ubuntu)
     Importance: Undecided
         Status: New

--
You received this bug notification because you are a member of Lubuntu
Packages Team, which is subscribed to lxsession in Ubuntu.
https://bugs.launchpad.net/bugs/1423326

Title:
  lxsession should depend on lxsession-logout

Status in lxsession package in Ubuntu:
  New

Bug description:
  I'm using Ubuntu 15.04 dev with lxsession 0.5.1-1ubuntu1 and if I'm
  not wrong lxsession depended on lxsession-logout which got now removed
  from the dependency list. But removing this package resulted on my
  system that the logout window doesn't appear anymore so maybe it
  should get a dependency again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxsession/+bug/1423326/+subscriptions

> Are you saying, you were unable to log out of your system?

Since the logout window doesn't appear anymore if the package gets removed (or not installed at all) this is correct.

It's true that removing lxsession-logout will render you unable to logout of the desktop using the desktop logout button.

Running this command:
$ sudo apt-get purge lxsession-logout

Results in: http://paste.ubuntu.com/10558139

Relevant bit:
The following packages will be REMOVED:
  lubuntu-core* lubuntu-default-session* lubuntu-default-settings*
  lubuntu-desktop* lxsession-logout*

This is a tangled web of dependencies. After rebooting (with "sudo reboot"), I have more or less an LXDE desktop, but without the Lubuntu style. Trying to hit "Logout" from this interesting thing seems to do nothing, but then 5 seconds later, x screensaver goes into effect - apparently it defaults to "lock screen option" when lxsession-logout is removed.

Most things still function just fine.

This might be something to look at on a wishlist, but I don't think removing lxsession-logout is a likely occurrence.

> Relevant bit:
> The following packages will be REMOVED:
> lubuntu-core* lubuntu-default-session* lubuntu-default-settings*
> lubuntu-desktop* lxsession-logout*
>
> This is a tangled web of dependencies. After rebooting (with "sudo reboot"), I have more or less an LXDE desktop, but
> without the Lubuntu style.

LXDE != Lubuntu. For example I'm still on Ubuntu just with some LXDE packages but with no Lubuntu packages.

> This might be something to look at on a wishlist, but I don't think removing lxsession-logout is a likely occurrence.

It is not only about removing lxsession-logout as it is now not guaranteed anymore that it gets installed if somebody wants to install LXDE on its Ubuntu system.

apt-cache show lxsession-logout describes lxsession-logout as

Package: lxsession-logout
Priority: optional
Section: universe/x11
Installed-Size: 70
Maintainer: Ubuntu Developers <email address hidden>
Original-Maintainer: Debian LXDE Maintainers <email address hidden>
Architecture: amd64
Source: lxsession
Version: 0.5.1-1ubuntu1
Replaces: lxsession (<< 0.4.9.2)
Depends: libc6 (>= 2.4), libcairo2 (>= 1.2.4), libgdk-pixbuf2.0-0 (>= 2.22.0), libglib2.0-0 (>= 2.26.0), libgtk2.0-0 (>= 2.24.0), libx11-6, lxsession-data, consolekit
Recommends: lsb-release
Filename: pool/universe/l/lxsession/lxsession-logout_0.5.1-1ubuntu1_amd64.deb
Size: 14142
MD5sum: aea666d03bac644d327d69463136a581
SHA1: f0a4b2bfad3506363da11be2f8d4c13e3dadb000
SHA256: f77a2fe72636eac823d3851830262bd6cec55f201b0ce425991b291f625507be
Description-en: utility to logout from a LXDE or an Openbox session
 LXSession-Logout is a simple utility for stoping or loging out from a LXDE or
 an Openbox session.
Description-md5: 6b80f851468390c906650e6d1f4bc784
Homepage: http://www.lxde.org/
Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Origin: Ubuntu
Task: lubuntu-core

The point of lxesssion-logout is to allow you to log out of LXDE or openbox session so why wouldn't removing the way to let you log out and then not let you log out be the intended behavior.

I don't see a reason to do things but users could remove it by mistake. Or make a stupid boastful statement while maybe being intoxicated "like I am such an elite linux user I make it so I have to shutdown via the command line. "

If they then regret this is would be easier for them to login to an lxde session and from synaptic or lubuntu software center undo their previous error which they may end up regretting making it harder for them to return to normal and improvment because if lxsession depends on lxsession-logut removing lxsession-logout will remove lxsession. Is not letting someone login because they cannot logout an improvment.

Also current bzr head of lxsession includes the code for lxsession-logout it just currently isn't in a released package. If I run sudo apt-get install lxde from an install of 15.04 from the server iso I am unable to log out. If lxsession-logout stays a seperate package that could be a recommends or or depends on lxde.

On Sat, 07 Mar 2015 21:51:52 -0000
Sworddragon <email address hidden> wrote:

> guaranteed anymore that it gets installed if somebody wants to install
Actually if you are using lxde and not lubuntu can you please put that info in bugs you report so I do not make wrong assumptions or get in arguments over miscommunication. It will make everyone's life easier as you won't have to answer triager question with wrong assumption and will make it easier to get the problem fixed which is why you would follow bugs in the first place.
--
Brendan Perrine <email address hidden>

This is a valid bug.

trusty and utopic are not affected, as both have lxsession packages that depend on lxsession-logout.

I believe the importance should be set to low, as installing LXDE on vanilla Ubuntu instead of installing Lubuntu or lubuntu-desktop will probably not be an action taken by most users.

Can you confirm if installing lxsession-logout fixes this bug? "sudo apt-get install lxsession-logout"

Perhaps additional testing should be done, as there are several other packages that were dependencies of previous lxsession packages that are no longer dependencies:

output of apt-cache depends lxsession (Utopic vs Vivid): https://www.diffchecker.com/ke7jzylm

> Actually if you are using lxde and not lubuntu can you please put that info in bugs you report so I do not make wrong
> assumptions or get in arguments over miscommunication.

This information was already always available in the startpost.

> Can you confirm if installing lxsession-logout fixes this bug?

Yes, installing lxsession-logout causes the logout window to appear again.

This should be resolved before the Vivid release, as lxsession-logout is one of the things listed on the lxsession0.5.1-1ubuntu1 changelog for "Ubuntu remaining changes ": https://launchpad.net/ubuntu/+source/lxsession/0.5.1-1ubuntu1

This has just happened for me on Ubuntu 16.04 Server.

Attached is the fix for this bug. It adds lxsession-logout to the Recommends for lxsession.

The reason I added this to the recommends is because lxde-core and other lxde-related packages are in Recommends and packages like lsb_release are in Depends, and in my opinion, it fits better in Recommends.

Initially I have targeted to get lxsession-logout in the Depends field but now I have no strong opinion about this. It should go to the Depends field if lxsession-logout provides a significant amount of functionality for lxsession.

@Sworddragon I just looked at what already was in Depends and Recommends. Recommends had lxde-core while Depends had systemd. While lxsession-logout provides the ability to log out, I was just looking at the types of packages in each respective entry.

Am I wrong in doing that? Should it go in Depends?

> Should it go in Depends?

I don't know enough in detail about the functionality of lxsession and lxsession-logout to be able to tell you this.

I don't think lxsession-logout should be a depends of lxsession, because lxsession works perfectly without it. In fact, people may want another way to log out that lxsession-logout. There is other logout utilities that work with lxsession.

I have no strong opinion about adding lxsession-logout in the recommends field of lxsession. That make sense, but it doesn't fix the "problem" for people who will remove the package and try to log out by clicking on the lxpanel shortcut. If there is a default setting using lxsession-logout in lxpanel, that's the same issue (it means, lxpanel needs also a recommend of lxsession-logout).

@Julien so what do you suggest needs to be done now?

Apparently this is still being disputed, so unsubcribing sponsors for now. Please re-subscribe once there is an agreed-upon patch.

JFYI: logout was working fine with 15.x release, but it seems the package was automatically uninstalled during upgrade to 16.x. Installing logout back through apt fixed the issue, but IMHO that is not a smooth experience for common user.

This bug was fixed in the package lxsession - 0.5.3-1ubuntu1

---------------
lxsession (0.5.3-1ubuntu1) zesty; urgency=medium

  * Re-sync with Debian. Ubuntu remaining changes :
  * debian/control:
   - Keep built-in support, since qt session use lxqt-session.
   - Add Replaces: lxsession-data (<< 0.5.3-1) for lxsession.

lxsession (0.5.3-1) unstable; urgency=medium

  [ Julien Lavergne ]
  * Stop building built-in support, for easy integration with qt session.

  [ Andriy Grytsenko ]
  * Rebuild all .c from .vala to be up to date.
  * Changing Maintainer e-mail to Alioth based one.
  * Using https for VCS fields in debian/control file.
  * Using dh-autoreconf instead of autotools-dev.
  * Adding dependency on policykit-1 (Closes: #773126, #773480, #814915).
  * Replacing Provides policykit-1-gnome with polkit-1-auth-agent
    (Closes: #826490, #842267).
  * Removing override_dh_strip rule from debian/rules.
  * Removing upower (<< 0.99) from Depends, it's not available anymore.
  * Merging upstream version 0.5.3.
  * Adding libunique-dev to Build-Depends.
  * Bump Standards-Version to 3.9.8.
  * Adding laptop-detect to Depends on lxsession as it tries to run that
    utility.
  * Updating lxsession-xsettings in lxsession.install, it was moved.
  * Removing 01-no-dup-polkit.patch, it's included by upstream.
  * Removing 02-fix-db-update.patch, it's included by upstream.
  * Enabling hardening (set DEB_BUILD_MAINT_OPTIONS indebian/rules).
  * Recommend lxde-session instead of lxde-common.
  * Don't recommend openbox, lxde-session will depend on it instead.
  * Splitting out lxsession-data package.
  * Splitting out lxsession-edit package.
  * Splitting out lxpolkit package.
  * Splitting out lxlock package.
  * Split out lxsession-logout package. It can be used independently
    (LP: #1423326).
  * Split out lxsession-default-apps package, it may be optional.
  * Splitting out lxde-settings-daemon package, lxsession does not need it
    but it can be used independently instead.
  * Adding manual pages coming with package to install (Closes: #722037).
  * Adding proper dependency from lxlock to supported screen lockers
    (Closes: #780024).

 -- Julien Lavergne <email address hidden> Fri, 23 Dec 2016 11:51:29 +0100

Was just hit by this bug after `apt install lxde` in LXC container under 16.04 server. Considering that it installed tons of other stuff (more than 1GB) it was just shock to find out that logout is missing. How is it even optional, if red button in the south east corner invokes it? Why is it still not fixed in LTS?