native-origins.d information causes apport to strip origin information from Package

Bug #1470572 reported by Brian Murray
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Apport
Fix Released
Undecided
Unassigned
apport (Ubuntu)
Fix Released
High
Unassigned
Trusty
Fix Released
High
Brian Murray
Vivid
Fix Released
High
Brian Murray

Bug Description

I've discovered that if you have a file in /etc/apport/native-origins.d/ for a PPA then that origin information is stripped from the Package field of the report.

Test Case
1) Ensure that /etc/apport/native-origins.d/thunderbird contains LP-PPA-mozillateam-thunderbird-next
2) sudo add-apt-repository ppa:mozillateam/thunderbird-next
3) sudo apt-get update
4) sudo apt-get install thunderbird
5) ubuntu-bug thunderbird (apport-cli thunderbird)
6) view package field in the report

Package: thunderbird 1:38.0~b6+build2-0ubuntu1

Instead I would expect the Package field to contain a "[origin: LP-PPA-mozillateam-thunderbird-next]" after the Package name. Additionally, my branch to retrace packages from PPAs depends on the origin information being there.

Discussing this with pitti he said that "this needs fixing".

Related branches

Changed in apport (Ubuntu):
importance: Undecided → High
status: New → Confirmed
tags: added: wily
Revision history for this message
Martin Pitt (pitti) wrote :

Right, I suppose my original thinking was "only non-native packages should be marked that way, to stand out when a developer looks at it". But this collides with the use case of retracing with PPA support, as we need to find these packages. So we need to be careful to not start rejecting these bugs; i. e. that apport.packaging.is_distro_package() does not cause UnreportableReason=="this is not an official package blabla".

Changed in apport (Ubuntu):
status: Confirmed → Triaged
Changed in apport:
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in trunk r2978, thanks Brian!

Changed in apport:
status: Triaged → Fix Released
Changed in apport (Ubuntu):
status: Triaged → Fix Committed
Changed in apport (Ubuntu Trusty):
status: New → Triaged
Changed in apport (Ubuntu Vivid):
status: New → Triaged
Changed in apport (Ubuntu Trusty):
importance: Undecided → High
Changed in apport (Ubuntu Vivid):
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.18-0ubuntu2

---------------
apport (2.18-0ubuntu2) wily; urgency=medium

  * Fix PEP-8 error in test/test_backend_apt_dpkg.py.

apport (2.18-0ubuntu1) wily; urgency=medium

  * New upstream release. Changes since our last merge from trunk:
    - apport-gtk: Use GtkWidget::valign property instead of GtkMisc::yalign
      which is deprecated in GTK 3.16. Thanks Iain Lane.
    - sandboxutils, make_sandbox(): Don't exit with 0 (success) if the
      ExecutablePath does not exist. (LP: #1462469)
    - sandboxutils, make_sandbox(): Fix second round of package installs to go
      into permanent root dir as well.
    - apt/dpkg install_packages(): If a requested package version is not
      available from apt in the given archive, try to download it from
      Launchpad. Thanks to Brian Murray!
    - kerneloops: Fix crash when determining the version of a custom kernel.
      Thanks Brian Murray. (LP: #1468154)
    - apt/dpkg install_packages(): Ignore -dbg packages whose descriptions
      contain "transitional". (LP: #1469635)
    - Keep "[origin: ...]" information in Package: and Dependencies: fields
      for native-origins.d/ origins, so that it's possible to retrace them.
      Thanks Brian Murray! (LP: #1470572)
    - Add support for retracing with discovering and enabling foreign
      Launchpad PPA origins, as specified in reports' Package:/Dependencies:
      fields. Thanks Brian Murray!
    - hookutils.attach_wifi(): Shorten value of CRDA if iw isn't available on
      the system. Thanks Brian Murray.
    - Fix wrong assertion in crashdb.test_check_duplicate() which surfaces
      under Python 3.5. (LP: #1474539)
  * test/test_backend_apt_dpkg.py: Disable new test assertion for
    unity-services-dbgsym, which doesn't currently work in the autopkgtest
    (but works fine in trunk and on the retracers). To be investigated.

 -- Martin Pitt <email address hidden> Fri, 17 Jul 2015 11:43:37 +0200

Changed in apport (Ubuntu):
status: Fix Committed → Fix Released
Changed in apport (Ubuntu Vivid):
assignee: nobody → Brian Murray (brian-murray)
status: Triaged → In Progress
Changed in apport (Ubuntu Trusty):
status: Triaged → In Progress
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Brian, or anyone else affected,

Accepted apport into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.14.1-0ubuntu3.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in apport (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in apport (Ubuntu Vivid):
status: In Progress → Fix Committed
Revision history for this message
Chris J Arges (arges) wrote :

Hello Brian, or anyone else affected,

Accepted apport into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.17.2-0ubuntu1.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good on vivid.

(vivid-amd64)root@impulse:/home/bdmurray# grep "Package" /tmp/apport.thunderbird.li0mhy1d.apport
Package: thunderbird 1:40.0~b1+build3-0ubuntu0.15.04.1 [origin: LP-PPA-mozillateam-thunderbird-next]
PackageArchitecture: amd64
SourcePackage: thunderbird
(vivid-amd64)root@impulse:/home/bdmurray# apt-cache policy apport
apport:
  Installed: 2.17.2-0ubuntu1.3
  Candidate: 2.17.2-0ubuntu1.3
  Version table:
 *** 2.17.2-0ubuntu1.3 0
        500 http://192.168.10.7/ubuntu/ vivid-proposed/main amd64 Packages
        100 /var/lib/dpkg/status

Revision history for this message
Brian Murray (brian-murray) wrote :

And it also looks good on Trusty.

(trusty-amd64)root@impulse:/home/bdmurray# grep Package /tmp/apport.thunderbird.vimk8rjs.apport
Package: thunderbird 1:40.0~b1+build3-0ubuntu0.14.04.1 [origin: LP-PPA-mozillateam-thunderbird-next]
PackageArchitecture: amd64
SourcePackage: thunderbird
(trusty-amd64)root@impulse:/home/bdmurray# apt-cache policy apport
apport:
  Installed: 2.14.1-0ubuntu3.12
  Candidate: 2.14.1-0ubuntu3.12
  Version table:
 *** 2.14.1-0ubuntu3.12 0
        500 http://192.168.10.7/ubuntu/ trusty-proposed/main amd64 Packages
        100 /var/lib/dpkg/status

tags: added: verificaiton-done-vivid verification-done-trusty
removed: verification-needed
tags: added: verification-done-vivid
removed: verificaiton-done-vivid
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.14.1-0ubuntu3.12

---------------
apport (2.14.1-0ubuntu3.12) trusty-proposed; urgency=medium

  * Keep "[origin: ...]" information in Package: and Dependencies: fields
    for native-origins.d/ origins, so that it's possible to retrace them and
    so that bugs are reported about the right project. (LP: #1470572)
  * general-hooks/ubuntu.py: for reports where the ProblemType is Package
    always include information about the apt and dpkg versions.

 -- Brian Murray <email address hidden> Tue, 11 Aug 2015 12:33:43 -0700

Changed in apport (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for apport has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.17.2-0ubuntu1.3

---------------
apport (2.17.2-0ubuntu1.3) vivid-proposed; urgency=medium

  * Keep "[origin: ...]" information in Package: and Dependencies: fields
    for native-origins.d/ origins, so that it's possible to retrace them and
    so that bugs are reported about the right project. (LP: #1470572)

 -- Brian Murray <email address hidden> Tue, 11 Aug 2015 11:51:41 -0700

Changed in apport (Ubuntu Vivid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.