Ubuntu
dahdi-linux package

Improve dep-8 testing of DKMS modules

Bug #1497982 reported by Stefan Bader
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dahdi-linux (Ubuntu)
Fix Released
Low
Stefan Bader
Trusty
Fix Released
Low
Unassigned

Bug Description

Currently the dahdi-dkms modules are tested through auto-testing only by the generic DKMS package test. This does an install and checks whether this is successful. For dahdi-dkms this can be improved by actually loading the dahdi_dummy module.
Also, though this is more specifically and issue with Trusty (hence the nomination), there used to be an inconsistency with the echo (noise cancellation) module. For quite a while now this is provided by the kernel itself and at a version level which the same as the DKMS sources contain. For recent packaging we prevent the DKMS package from building that module, but back in Trusty it is done but not installed by DKMS. Which then results in a warning text in the output of "dkms status". This seems to cause a test failure for the generic test case.

So for Trusty I would also backport the dep-8 testcase (which seems less intrusive than doing anything to the build itself) get the improved testing and have the status test ignore the additional warning.

Revision history for this message
Stefan Bader (smb) wrote :
Changed in dahdi-linux (Ubuntu Trusty):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dahdi-linux - 1:2.10.0.1~dfsg-1ubuntu4

---------------
dahdi-linux (1:2.10.0.1~dfsg-1ubuntu4) wily; urgency=low

  * Improve dep-8 testing by supplying individual test case (which will
    also test-load the dummy module) (LP: #1497982)

 -- Stefan Bader <email address hidden> Mon, 21 Sep 2015 08:57:25 -0500

Changed in dahdi-linux (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Stefan Bader (smb) wrote :

SRU Justification:

Impact: Right now our generic DKMS tests in Tusty/14.04.x fail for dahdi-linux because the "dkms status" command will return a installed with warning type of message. That way we cannot catch any regressions (more important for the HWE kernels).

Fix: Add a specific dep-8 test which can handle the warning (and also test loads one of the produced modules).

Testcase: adt-test runs

Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Stefan, or anyone else affected,

Accepted dahdi-linux into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dahdi-linux/1:2.5.0.1+dfsg-1ubuntu4~14.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dahdi-linux (Ubuntu Trusty):
status: Triaged → Fix Committed
Revision history for this message
Stefan Bader (smb) wrote :

Looking at our test matrix I see the the specific testing (which got added) to be run. The build fails for some reason (while local tests succeed). But I would put that as a different problem and mark the improved testing as verified as it is attempted at least.
Potentially the failure is again the result of the build requiring to download firmware blobs from external sources...

tags: added: verification-done
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dahdi-linux - 1:2.5.0.1+dfsg-1ubuntu4~14.04.3

---------------
dahdi-linux (1:2.5.0.1+dfsg-1ubuntu4~14.04.3) trusty; urgency=low

  * debian/tests: Add special dep-8 test code as the generic testing
    fails because one module (echo.ko) is compiled but not installed
    since the kernel ships the same version (this has been fixed in
    newer packaging) (LP: #1497982).

 -- Stefan Bader <email address hidden> Mon, 21 Sep 2015 10:42:43 -0500

Changed in dahdi-linux (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for dahdi-linux has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.