[FFe] Update to moodle 3.0.3

Bug #1562172 reported by Nish Aravamudan
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
moodle (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

FFe justification: moodle 2.7.12 does not support PHP7. Moodle upstream
only supports PHP7 with moodle 3.0.1 or greater:
 - https://tracker.moodle.org/browse/MDL-50565
 - https://docs.moodle.org/dev/Moodle_and_PHP7

Tags: patch
Revision history for this message
Nish Aravamudan (nacc) wrote :

With the attached debdiff, moodle 3.0.3+dfsg-0ubuntu1 succesfully builds.

To generate the unmodified moodle-3.0.3.orig.tar.gz, uscan can now be used, as the watch file is corrected. To generate moodle-3.0.3+dfsg.orig.tar.gz, run the commands as specified in debian/rules. That should result in a clean lintian run.

Please let me know if you'd prefer I provide the tarballs directly.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "moodle_2.7.12+dfsg-1.3.0.3+dfsg-0ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Logan Rosen (logan) wrote :

I have subscribed ~ubuntu-release to this bug per the freeze exception documentation [1]. We'd prefer that you wait to subscribe ~ubuntu-sponsors until/if the FFe is approved - thanks! I've removed ~ubuntu-sponsors from the subscribers accordingly, for now.

[1] https://wiki.ubuntu.com/FreezeExceptionProcess

Revision history for this message
Steve Langasek (vorlon) wrote :

The standard tradeoff: existing package only supports php5, which will be removed for release; options are to upgrade the package or remove it: a new upstream release exists that supports php7. FFe granted.

Changed in moodle (Ubuntu):
status: New → Confirmed
Revision history for this message
Nish Aravamudan (nacc) wrote :
Revision history for this message
Steve Langasek (vorlon) wrote :

I might suggest future-proofing some of the lintian overrides, so that they don't need to be updated every time the version of the component (and thus the filesystem path) changes.

There are also these lintian warnings on the binary package, looks like you didn't update debian/moodle.lintian-overrides, only the sourceful one:

W: moodle: embedded-javascript-library usr/share/moodle/lib/editor/tinymce/tiny_mce/3.5.11/tiny_mce.js please use tinymce
W: moodle: embedded-javascript-library usr/share/moodle/lib/editor/tinymce/tiny_mce/3.5.11/tiny_mce_popup.js please use tinymce
W: moodle: embedded-javascript-library usr/share/moodle/lib/editor/tinymce/tiny_mce/3.5.11/tiny_mce_src.js please use tinymce
W: moodle: extra-license-file usr/share/moodle/lib/htmlpurifier/LICENSE
W: moodle: embedded-javascript-library usr/share/moodle/lib/jquery/ui-1.11.4/external/jquery/jquery.js please use libjs-jquery
W: moodle: extra-license-file usr/share/moodle/lib/lessphp/LICENSE
W: moodle: extra-license-file usr/share/moodle/lib/mustache/LICENSE
W: moodle: extra-license-file usr/share/moodle/lib/requirejs/LICENSE
W: moodle: embedded-javascript-library usr/share/moodle/lib/yuilib/3.17.2/yui/yui-min.js please use libjs-yui
W: moodle: extra-license-file usr/share/moodle/mod/assign/feedback/editpdf/fpdi/LICENSE
E: moodle: php-script-but-no-phpX-cli-dep usr/share/moodle/admin/mailout-debugger.php
E: moodle: php-script-but-no-phpX-cli-dep usr/share/moodle/admin/process_email.php
N: 2 tags overridden (2 warnings)

Attached is a patch to fix the majority of these, except two:

 - The php-script-but-no-phpX-cli-dep is a bug in lintian, the long description of the lintian error says as much. Should be fixed there instead of here.
 - Although the previous version of moodle already bundled jquery, lintian did not report on it. Rather than assuming this bundling is correct and appropriate and overriding the warning, I'm leaving the warning unmasked. It's possible that with the current version of libjs-jquery available in Ubuntu, linking might be more appropriate than bundling. There's no requirement to address this before release because it's not a regression, but let's not make the issue harder to spot.

With these changes, the package looks good to me, so sponsoring.

Revision history for this message
Steve Langasek (vorlon) wrote :

Also, the dput of this new upstream source took just long enough to annoy me that, since it's a +dfsg tarball (so no upstream checksum that matters) and we have a 3.0 (quilt) package, I'm recompressing the tarball with xz.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package moodle - 3.0.3+dfsg-0ubuntu1

---------------
moodle (3.0.3+dfsg-0ubuntu1) xenial; urgency=medium

  [ Nishanth Aravamudan ]
  * New upstream release, as only 3.0.1+ has PHP7 support
    (LP: #1562172).
    - https://docs.moodle.org/dev/Moodle_and_PHP7
    - https://tracker.moodle.org/browse/MDL-50565
    - update d/rules dfsg target.
    - remove mdeploy*.php from d/install.
    - d/lintian-overrides, d/source/lintian-overrides: update embedded
      tinymce, yuilib, jquery versions.
    - d/rules: update override_dh_lintian.
  * d/control: update to PHP7.0 dependencies.
  * d/watch: correct for current releases.

  [ Steve Langasek ]
  * Also update lintian overrides for binary packages.
  * Remove some additional license files.
  * Drop some no-longer-applicable lintian overrides.

 -- Steve Langasek <email address hidden> Fri, 01 Apr 2016 22:08:56 -0700

Changed in moodle (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.