help.launchpad.net is invisible in Internet Explorer

Bug #162322 reported by Matthew Paul Thomas
4
Affects Status Importance Assigned to Milestone
Launchpad Help Wiki Moin theme
Fix Released
High
Joey Stanford

Bug Description

Philippe Verdy reports that help.launchpad.net pages cannot be read in Internet Explorer:

------------
I just see the decorations, the central content is empty.
...
The invisible part of the page is all what is within:

<div id="container">
  <div id="maincontent">
    <div class="pageheading"><!-- XXX obsolete --></div>
    <div>
      <div lang="en" id="content" dir="ltr">
       <a id="top"></a>
       ...(the wiki content)...
      </div>
    </div>
  </div>
  <div id="portlets">
    <div id="actions" class="portlet">
      <h2>Wiki Destinations</h2>
      ...
    </div>
    <div class="portlet">
      <h2>Page Actions</h2>
      ...
    </div>
  </div>
  <div class="clear"></div><!-- needed for Safari -->
</div>

After looking at the code, this seems related to a bug in the website CSS
stylesheet:

http://launchpad.net/+icing/rev3/style.css
line 70:

#maincontent {
  ...
  display:inline;
  float:left;
  position:relative;
}

A "display:inline" element cannot float left... This should be
"display:block". And if it is floating, it can't be positioned at relative
position. There's some contradiction, and the result is unpredictable, as
one of these properties must be ignored (normally the last option wins, but
this is not guaranteed).

Changing it to "display:block" should solve the problem.
------------

Tags: ui
description: updated
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Problem reproduced by Katie at Brilliant.

Changed in launchpad:
importance: Undecided → Critical
status: New → Confirmed
Changed in launchpad-documentation:
assignee: nobody → mpt
importance: Critical → High
Changed in launchpad-documentation:
assignee: mpt → newz
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Changing "display: inline" to "display: block" does not solve the problem.

The culprit seems to be the #container rule in style.css. If the "position: relative" line is removed, the text reappears. I don't know why the line is there.

Revision history for this message
Joey Stanford (joey) wrote :

I fixed this as well (inadvertently) when I fixed the other theme items. Tested on XP SP2 with IE7

Changed in launchpad-documentation:
assignee: newz → rinchen
status: Confirmed → Fix Released
milestone: none → 1.2.2
Revision history for this message
Skids (rpalmer-sominet) wrote :

It still doesn't work. IE7 - XP SP2

Revision history for this message
Joey Stanford (joey) wrote :

Skids, please attach a screenshot please. I can't replicate this. It works for me on XP SP2 with IE7.

Revision history for this message
Joey Stanford (joey) wrote :

As luck would have it, by another route I was looking at Bug #90545 and noticed that the code block is different (newer) than what's in the help wiki.
So, I'll try to add this to the code and see if it works.

<!--[if IE 7]>
 <style type="text/css">
  #portlets {
   left: 20px !important;
   right: none;
  }
 </style>
<![endif]-->

Revision history for this message
Joey Stanford (joey) wrote :

I ran browsershots and it reports ie7 working fine although it did expose an error with IE5.5 on win 2000 which I'm not going to fix (the portlets are centered instead of left justified)

Revision history for this message
Joey Stanford (joey) wrote :

I've just tested the patch above vs what's in the theme today and the only real change is that it lowers the portlets on the left hand side a few pixels. I don't think this is change for the better so I'm going to leave the theme as is for now. Both versions work on my XP 2 IE7 installation with no errors.

Joey Stanford (joey)
Changed in launchpad-documentation:
milestone: 1.2.2 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.