Regression in pdo_pgsql after SRU to php 7.0.13 (fixed upstream)

Bug #1658289 reported by David Hedberg
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
php7.0 (Ubuntu)
Fix Released
High
Unassigned
Xenial
Fix Released
High
Unassigned
Yakkety
Fix Released
High
Unassigned

Bug Description

[Impact]

* Running PDO::lastInsertId() using a bad sequence name (not updated or nonexistent) no longer throws an exception.

* This is a functional regression in upstream PHP between 7.0.8 and 7.0.13, which was previously SRU'd to xenial and yakkety.

[Test Case]

* https://github.com/php/php-src/blob/master/ext/pdo_pgsql/tests/bug73959.phpt which was added in the upstream commit that fixed the issue.

* I have backported the test-case along with the SRU'd versions, and the test suite is run at build and autopkgtest time.

[Regression Potential]

* This is an upstream bugfix with a small and contained solution, I believe the regression potential is minimal; in fact, we regressed in the prior SRU, so this returns lost functionality.

--

After upgrading php7.0 to 7.0.13-0ubuntu0.16.04.1 from xenial-updates, we had a couple of failed tests in our internal test suite.

I reported php bug #73959, which was then fixed in commit 21ac79e94bd0335bf885b807e09c4d86d75d776a.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I subscribed Nish who was driving the update you referred to.

Revision history for this message
Nish Aravamudan (nacc) wrote :

This is now fixed in 17.04, I'm working on the SRU(s) to 16.04 and 16.10 now.

Changed in php7.0 (Ubuntu):
status: New → Fix Released
Revision history for this message
Robie Basak (racb) wrote :

Upstream report: https://bugs.php.net/bug.php?id=73959
Upstream commit: http://git.php.net/?p=php-src.git;a=commit;h=21ac79e94bd0335bf885b807e09c4d86d75d776a

I'm pleased to see that the fix landed alongside a regression test.

tags: added: regression-update
Revision history for this message
Robie Basak (racb) wrote :

It doesn't look like this is fixed in 7.0.15 to me. http://php.net/ChangeLog-7.php doesn't list the bug, and suggests that 7.0.15 was released on 19 Jan. The upstream fix was written and committed on 20 Jan. I looked at queue/xenial/unapproved/096b3ce (tree id d3103de) and this doesn't appear to have the fix (it still has the line that was dropped upstream).

Changed in php7.0 (Ubuntu):
status: Fix Released → Triaged
Nish Aravamudan (nacc)
Changed in php7.0 (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello David, or anyone else affected,

Accepted php7.0 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/php7.0/7.0.15-0ubuntu0.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in php7.0 (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Changed in php7.0 (Ubuntu Yakkety):
status: New → Fix Committed
Revision history for this message
Robie Basak (racb) wrote :

Hello David, or anyone else affected,

Accepted php7.0 into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/php7.0/7.0.15-0ubuntu0.16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Nish Aravamudan (nacc)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package php7.0 - 7.0.15-1ubuntu2

---------------
php7.0 (7.0.15-1ubuntu2) zesty; urgency=medium

  * debian/patches/0050-Fix-pdo_pgsql.patch: Fixed #73959 - lastInsertId
    fails to throw an exception in pdsql. Thanks to andrewnester
    <email address hidden>. Closes LP: #1658289.

 -- Nishanth Aravamudan <email address hidden> Tue, 14 Feb 2017 13:44:31 -0800

Changed in php7.0 (Ubuntu):
status: Fix Committed → Fix Released
Mathew Hodson (mhodson)
Changed in php7.0 (Ubuntu):
importance: Undecided → High
Changed in php7.0 (Ubuntu Xenial):
importance: Undecided → High
Changed in php7.0 (Ubuntu Yakkety):
importance: Undecided → High
Revision history for this message
David Hedberg (david-hedberg-t) wrote :

Tested OK.

I first reproduced the original bug using 7.0.13-0ubuntu0.16.04.1. I then upgraded to 7.0.15-0ubuntu0.16.04.1 from -proposed and verified that the bug was fixed.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for php7.0 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package php7.0 - 7.0.15-0ubuntu0.16.10.1

---------------
php7.0 (7.0.15-0ubuntu0.16.10.1) yakkety; urgency=medium

  * New upstream release
    - LP: #1663405
    - Refresh patches for new upstream release.
  * debian/patches/0048-Fix-pdo_pgsql.patch: Fixed #73959 - lastInsertId
    fails to throw an exception in pdsql. Thanks to andrewnester
    <email address hidden>. Closes LP: #1658289.

 -- Nishanth Aravamudan <email address hidden> Tue, 14 Feb 2017 14:44:43 -0800

Changed in php7.0 (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package php7.0 - 7.0.15-0ubuntu0.16.04.1

---------------
php7.0 (7.0.15-0ubuntu0.16.04.1) xenial; urgency=medium

  * New upstream release
    - LP: #1663405
    - Refresh patches for new upstream release.
  * debian/patches/0050-Fix-pdo_pgsql.patch: Fixed #73959 - lastInsertId
    fails to throw an exception in pdsql. Thanks to andrewnester
    <email address hidden>. Closes LP: #1658289.

 -- Nishanth Aravamudan <email address hidden> Tue, 14 Feb 2017 14:53:34 -0800

Changed in php7.0 (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
bhat3 (bhat3) wrote :

@Nish & Co: Actually Marc put that into -security so i am facing: "Package 'php7.0-fpm' has conffile prompt and needs to be upgraded manually" on a lot of machines with pure (lame) MySQL. But it's a regression fix to a security update, but no real security update right?

Revision history for this message
Nish Aravamudan (nacc) wrote : Re: [Bug 1658289] Re: Regression in pdo_pgsql after SRU to php 7.0.13 (fixed upstream)

On Wed, Mar 1, 2017 at 12:24 AM, bhat3 <email address hidden> wrote:
> @Nish & Co: Actually Marc put that into -security so i am facing:
> "Package 'php7.0-fpm' has conffile prompt and needs to be upgraded
> manually" on a lot of machines with pure (lame) MySQL. But it's a
> regression fix to a security update, but no real security update right?

Can you pastebin the conffile prompt you are getting? The update was a
straight mainline update with no changes to conffiles or debian/
beyond refreshing patches and adding the one d/patch.

Note that the reason 7.0.15 went into -security as well as -updates is
that there was a security update planned for the 7.0.13 release, but
we were going to SRU in 7.0.15 anyways, and it included the security
fixes.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.