virt-install fails on s390x with options --location and --extra-args

The virt-manager version in Debian stretch is not affected by the --extra-args issue, but is subject to the --location failure.

Hiho,

4c3e796 virt-install: concatenate all extra-args argument
=> this is in since 1.4.0 and therefore good since the latest merge to 1:1.4.0-5ubuntu1

f248088 virtinst: adjust media paths for s390x
=> this OTOH is just 1 day old from:
Author: Viktor Mihajlovski <email address hidden>
Date: Tue Aug 29 15:51:43 2017 +0200

Hi Victor btw o/ !

There is a follow on fix to the self tests that "belongs" to that which is:
commit 427592bc7b9cab676456dbee11922f2bc61380a1 (HEAD -> master, origin/master, origin/HEAD)
Author: Cole Robinson <email address hidden>
Date: Tue Aug 29 11:57:45 2017 -0400

While I'm not a virt-inst fan or user I see the use case and this is bug-fix only.
Not sure how important that is for an SRU since this didn't hurt anybody all the time, but lets start at Artful and consider more from there.

I'll take a look, but that should backport rather straight forward I'd think.

I also want a review for the final upload, but you could already test the ppa build at [1].

If you could confirm (artful) that this fixes the issue as you expect, that would be great.
I only uploaded now, so it might need a few minutes to build and publish virt-manager_1.4.0-5ubuntu2 there.

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/2935

------- Comment From <email address hidden> 2017-08-30 09:04 EDT-------
(In reply to comment #7)
> Hiho,
>
> 4c3e796 virt-install: concatenate all extra-args argument
> => this is in since 1.4.0 and therefore good since the latest merge to
> 1:1.4.0-5ubuntu1
Hi Christian, I know, but the issue is specifically with Xenial and we have still more than three years to go...
>
> f248088 virtinst: adjust media paths for s390x
> => this OTOH is just 1 day old from:
> Author: Viktor Mihajlovski <email address hidden>
> Date: Tue Aug 29 15:51:43 2017 +0200
>
> Hi Victor btw o/ !
>
> There is a follow on fix to the self tests that "belongs" to that which is:
> commit 427592bc7b9cab676456dbee11922f2bc61380a1 (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Cole Robinson <email address hidden>
> Date: Tue Aug 29 11:57:45 2017 -0400
I didn't need this patch to build the binary packages.
>
> While I'm not a virt-inst fan or user I see the use case and this is bug-fix
> only.
> Not sure how important that is for an SRU since this didn't hurt anybody all
> the time, but lets start at Artful and consider more from there.
>
Well, people take some time before the start to try out stuff on Z. The issue came up because a colleague needs to perform unattended installation of Xenial guests, and he's stuck now. So we really need that for Xenial (but not for the other releases preceding Artful).
> I'll take a look, but that should backport rather straight forward I'd think.

We do not recommend to use virt-install to create Ubuntu guest instances.

Instead, mirror and launch Ubuntu Cloud Image, with a cloud config drive to customize the instances.

You can find ready made Ubuntu Cloud Images for s390x at https://cloud-images.ubuntu.com/xenial/current/ note they are regularly refreshed to boot with latest kernel, SRU and security fixes.

You can customize the instances as needed using cloud-config stanzas http://cloudinit.readthedocs.io/en/latest/topics/examples.html

And one can trivially provide config-drive to the virtual machine using e.g. NoCloud http://cloudinit.readthedocs.io/en/latest/topics/datasources/nocloud.html

Have you considered using cloud-images to simply boot and initialize customized Xenial guests? It will complete provision much faster than d-i based methods.

------- Comment From <email address hidden> 2017-08-30 09:23 EDT-------
(In reply to comment #8)
> I also want a review for the final upload, but you could already test the
> ppa build at [1].
>
> If you could confirm (artful) that this fixes the issue as you expect, that
> would be great.
> I only uploaded now, so it might need a few minutes to build and publish
> virt-manager_1.4.0-5ubuntu2 there.
>
> [1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/2935

To my surprise and pleasure I could install the new virtinst deb on Xenial and could successfully install a KVM guest, with location, preseed and all. But, as I said ... it's broken in Xenial and the fix is needed there.

@Victor - three things:

1. ads Dimitri mentioned virtinst isn' recommended.
   I use cloud images all day via as Dimitri outlined.
   I do so via uvtool, but that also has a s390x issue (bug 1452016), but you can provide
   the template I provide there.
   From there you can use all you want and cloud-init your way as you need - Dimitri
   already added a lot of great links, no need to requote them.

2. that does not mean I won't consider fixing virt-manager if the changes clearly apply
   that is a fix worth to help you and others.
   Just expect if you hit other things in virtinst that it might not be the most
   used/tested/supported solution to achieve what you need.

3. Even if you are only interested in Xenial the SRU process defines to fix in currrent
   dev release and from there SRU back.
   Among other things that ensures that nobody encounters a regression on an update from
   Xenial to something newer.

I'll get back once I got a review on my change, that is blocked on someting unrelated on virt-manager for now.

I was able to reproduce on Artful and test the fix on my own as well.
I think it is a valid improvement and since all changes are upstream it is no permanent Delta burden.

That said pushing fix for artful.
And starting to consider SRU'ability

I added an SRU Template already, but need to
1. backport for SRUs
2. test backports

If one of them fails or gets more complex than expected we have to reconsider the SRU, but let me try first.

------- Comment From <email address hidden> 2017-08-31 05:05 EDT-------
(In reply to comment #11)
[snip]
> Have you considered using cloud-images to simply boot and initialize
> customized Xenial guests? It will complete provision much faster than d-i
> based methods.
FWIW: I was told that the cloud images were not usable because of special partitioning requirements for the guests (hence the need to use preseed).

This bug was fixed in the package virt-manager - 1:1.4.0-5ubuntu2

---------------
virt-manager (1:1.4.0-5ubuntu2) artful; urgency=medium

  * - d/p/virtinst-adjust-media-paths-for-s390x.patch: fix virtinst on
      s390x (LP: #1713990)

 -- Christian Ehrhardt <email address hidden> Wed, 30 Aug 2017 14:48:17 +0200

Artful complete, setting up MPs to review for SRUs:

On Testing from the PPAs [1][2] it worked for me fixing the issue and not wreaking other havoc.

MPs at [3][4]

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/2935
[2]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/2936
[3]: https://code.launchpad.net/~paelzer/ubuntu/+source/virt-manager/+git/virt-manager/+merge/329984
[4]: https://code.launchpad.net/~paelzer/ubuntu/+source/virt-manager/+git/virt-manager/+merge/329985

Got an ack on the MP.
Note: the MPs are redone and deleted since we (unrelated to this SRU) wrestle with the reimport of this package in USDI.

But:
- review complete
- Tests complete
- SRU Template complete
=> Uploading for SRU consideration

There is an old version 1.3.2-3ubuntu5 [1] that never appeared anywhere.
It was handled in Artful on the last merge to be correct.
In Zesty this change is only superseded/deleted and also now there is no reason to change this in Zesty.
Never the less it is part of the publishing history, so the upload for Zesty needs to be bumped to match (drop that change, mention in changelog and bump version).

Preparing ...

[1]: https://launchpad.net/ubuntu/+source/virt-manager/1:1.3.2-3ubuntu5 is

Fixed up the non-released zesty upload to be correctly included. It is now correctly dropped (in the changelog only as it never released) and the version bumped as needed.

That being complete Xenial and Zesty are ready for review by the SRU Team.

Crap it is really monday morning, of course ...
I beg your pardon - 1:1.3.2-3ubuntu5 was (first) to artful when while 1:1.3.2-3ubuntu4 was last Zesty.

The upload just accidentally mis-bumped the version and should have been 1:1.3.2-3ubuntu4.1 form the beginning.

The correct upload is ready, as soon as an SRU Team member rejected the wrong 1:1.3.2-3ubuntu6 from Zesty unapproved I can upload the right version.

Fixed the mistake and now I hope really ready for SRU team :-)

Hello bugproxy, or anyone else affected,

Accepted virt-manager into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/virt-manager/1:1.3.2-3ubuntu4.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello bugproxy, or anyone else affected,

Accepted virt-manager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/virt-manager/1:1.3.2-3ubuntu1.16.04.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

------- Comment From <email address hidden> 2017-09-08 04:32 EDT-------
This is to let you know that I've successfully tested the virtinst package (1:1.3.2-3ubuntu1.16.04.4) from xenial-proposed.

Tested the same on zesty, now able to install instead of being blocked by the images being not found.
Thanks Victor for doing the Xenial test.

This bug was fixed in the package virt-manager - 1:1.3.2-3ubuntu1.16.04.4

---------------
virt-manager (1:1.3.2-3ubuntu1.16.04.4) xenial; urgency=medium

  * Fix virtinst location on s390x and clobbering extra args (LP: #1713990)
    - d/p/bug-1713990-virt-install-concatenate-all-extra-args-argument.patch
    - d/p/bug-1713990-virtinst-adjust-media-paths-for-s390x.patch

 -- Christian Ehrhardt <email address hidden> Thu, 31 Aug 2017 09:49:42 +0200

The verification of the Stable Release Update for virt-manager has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package virt-manager - 1:1.3.2-3ubuntu4.1

---------------
virt-manager (1:1.3.2-3ubuntu4.1) zesty; urgency=medium

  * Fix virtinst location on s390x and clobbering extra args (LP: #1713990)
    - d/p/bug-1713990-virt-install-concatenate-all-extra-args-argument.patch
    - d/p/bug-1713990-virtinst-adjust-media-paths-for-s390x.patch

 -- Christian Ehrhardt <email address hidden> Thu, 31 Aug 2017 09:42:32 +0200