LVM-based install name of the root filesystem is not pretty

Bug #1782507 reported by Neha Deo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
partman-auto-lvm (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Milestone: Cosmic Daily
Product: Ubuntu Server amd64
Test case: Install (Default + crypted LVM) in Ubuntu Server amd64 in Cosmic Daily

Description: Mount location of the root file system should be /dev/mapper/ubuntu-root instead of /dev/mapper/ubuntu--vg-root

ProblemType: Bug
DistroRelease: Ubuntu 18.10
Package: debian-installer (not installed)
ProcVersionSignature: Ubuntu 4.15.0-23.25-generic 4.15.18
Uname: Linux 4.15.0-23-generic x86_64
ApportVersion: 2.20.10-0ubuntu5
Architecture: amd64
Date: Thu Jul 19 09:16:48 2018
InstallationDate: Installed on 2018-07-19 (0 days ago)
InstallationMedia: Ubuntu-Server 18.10 "Cosmic Cuttlefish" - Alpha amd64 (20180718)
Lsusb:
 Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
 Bus 002 Device 003: ID 0e0f:0002 VMware, Inc. Virtual USB Hub
 Bus 002 Device 002: ID 0e0f:0003 VMware, Inc. Virtual Mouse
 Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
MachineType: VMware, Inc. VMware Virtual Platform
MemoryUsage:
 total used free shared buff/cache available
 Mem: 2160688 216120 1689304 904 255264 1790552
 Swap: 1003516 0 1003516
ProcEnviron:
 TERM=linux
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_IN
 SHELL=/bin/bash
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-4.15.0-23-generic root=/dev/mapper/hostname--vg-root ro
SourcePackage: debian-installer
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 07/02/2015
dmi.bios.vendor: Phoenix Technologies LTD
dmi.bios.version: 6.00
dmi.board.name: 440BX Desktop Reference Platform
dmi.board.vendor: Intel Corporation
dmi.board.version: None
dmi.chassis.asset.tag: No Asset Tag
dmi.chassis.type: 1
dmi.chassis.vendor: No Enclosure
dmi.chassis.version: N/A
dmi.modalias: dmi:bvnPhoenixTechnologiesLTD:bvr6.00:bd07/02/2015:svnVMware,Inc.:pnVMwareVirtualPlatform:pvrNone:rvnIntelCorporation:rn440BXDesktopReferencePlatform:rvrNone:cvnNoEnclosure:ct1:cvrN/A:
dmi.product.name: VMware Virtual Platform
dmi.product.version: None
dmi.sys.vendor: VMware, Inc.

Revision history for this message
Neha Deo (nehadeo) wrote :
Revision history for this message
Ubuntu QA Website (ubuntuqa) wrote :

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/1782507

tags: added: iso-testing
tags: added: rls-cc-incoming
tags: removed: rls-cc-incoming
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

This isn't new, LVM-based installs have been showing this way for a while:

The names are built this way AFAIK:

 <name of the machine>-<name of the LVM LV>

Now, this gets transliterated to:
 <name of the machine>--<name of the LVM LV>

... because of how devmapper works, it "escapes" dashed with a double dash like that.

AFAICS, the naming is otherwise consistent. 'ubuntu' is the name of the machine, and "vg-root" is the effective name of the LV; and both of these are concatenated together with -- (as transliterated by devmapper).

Do we want to fix this to make it prettier? I've updated the bug title accordingly, it's question that we need to answer as a team (Foundations) being responsible in general for the installer, etc.

summary: - Mount location of root file system is not as expected
+ LVM-based install name of the root filesystem is not pretty
Changed in debian-installer (Ubuntu):
importance: Undecided → Low
tags: added: rls-ee-incoming
tags: added: rls-ee-notfixing
removed: rls-ee-incoming
affects: debian-installer (Ubuntu) → partman-lvm (Ubuntu)
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

The problem is that we create /dev/$VG/$LV , meaning that $VG name may not clash with any existing devices in /dev..... and hostnames sometimes do.

Hence we started doing "$hostname-vg" as the name. I wonder if we should switch to forexample "vg$hostname" or "vg_$hostname" which i think would be encoded without doubledash.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

or maybe just "$hostname_vg" will make things pretty enough, and e.g. consistent with $foo_crypt that we use for LUKS encrypted volumes.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

vg$hostname it is, i think camel case and mixed _- is ugly too.

affects: partman-lvm (Ubuntu) → partman-auto-lvm (Ubuntu)
Changed in partman-auto-lvm (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package partman-auto-lvm - 59ubuntu4

---------------
partman-auto-lvm (59ubuntu4) eoan; urgency=medium

  * Switch default VG name to vg$hostname, since $hostname-vg gets encoded
    doubledashed in /dev/mapper/. Also switch fallback VG name to
    vgubuntu. LP: #1782507

 -- Dimitri John Ledkov <email address hidden> Fri, 21 Jun 2019 01:45:12 +0100

Changed in partman-auto-lvm (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.