64-char hostname causes dhcp server to reject lease

Bug #1877176 reported by Dan Streetman
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
systemd (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Medium
Dan Streetman

Bug Description

[impact]

a systemd with a 64-character hostname (the maximum hostname length for Linux) will cause a dhcp server to reject its dhcp lease due to passing the invalid hostname in the dhcp lease request.

[test case]

$ cat /etc/systemd/network/10-ens3.network
[Match]
Name=ens3

[Network]
DHCP=yes

set hostname to 64-char name, e.g.:

$ sudo hostnamectl set-hostname a123456789b123456789c123456789d123456789e123456789f123456789g123

restart networkd:

$ sudo systemctl restart systemd-networkd

check logs:

root@a123456789b123456789c123456789d123456789e123456789f123456789g123:~# journalctl -b -u systemd-networkd --no-pager | grep 'DHCP error'
May 06 19:01:30 a123456789b123456789c123456789d123456789e123456789f123456789g123 systemd-networkd[737]: ens3: DHCP error: Client failed: Invalid argument

[regression potential]

Any regression would likely result in failure configuring/processing dhcpv4 server response, or rejection from the dhcpv4 server.

[scope]

this is fixed by commit 9740eae694e93b06658ff3b3045b22b591561e7c which is included in Bionic and later. This is needed only for Xenial.

[other info]

this is a follow on to bug 1862232, which corrected sd-dhcp-client.c to continue networkd dhcp even if the hostname is invalid, however the older code in Xenial doesn't correctly detect the invalid hostname, so this additional patch is needed.

Dan Streetman (ddstreet)
Changed in systemd (Ubuntu):
status: New → Fix Released
Changed in systemd (Ubuntu Xenial):
assignee: nobody → Dan Streetman (ddstreet)
importance: Undecided → Medium
status: New → In Progress
Dan Streetman (ddstreet)
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Dan, or anyone else affected,

Accepted systemd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/229-4ubuntu21.29 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in systemd (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (systemd/229-4ubuntu21.29)

All autopkgtests for the newly accepted systemd (229-4ubuntu21.29) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

systemd/229-4ubuntu21.29 (i386, amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#systemd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Dan Streetman (ddstreet) wrote :

xenial:

ubuntu@a123456789b123456789c123456789d123456789e123456789f123456789g123:~$ dpkg -l systemd|grep systemd
ii systemd 229-4ubuntu21.28 amd64 system and service manager
ubuntu@a123456789b123456789c123456789d123456789e123456789f123456789g123:~$ journalctl -b -u systemd-networkd | grep 'DHCP error'
Sep 09 18:30:30 a123456789b123456789c123456789d123456789e123456789f123456789g123 systemd-networkd[732]: ens3: DHCP error: Client failed: Invalid argument

ubuntu@a123456789b123456789c123456789d123456789e123456789f123456789g123:~$ dpkg -l systemd|grep systemd
ii systemd 229-4ubuntu21.29 amd64 system and service manager
ubuntu@a123456789b123456789c123456789d123456789e123456789f123456789g123:~$ journalctl -b -u systemd-networkd | grep 'DHCP error'

and did get a dhcp address:
ubuntu@a123456789b123456789c123456789d123456789e123456789f123456789g123:~$ ip a show ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 52:54:00:e1:a8:3f brd ff:ff:ff:ff:ff:ff
    inet 192.168.122.102/24 brd 192.168.122.255 scope global dynamic ens3
       valid_lft 3566sec preferred_lft 3566sec
    inet6 fe80::5054:ff:fee1:a83f/64 scope link
       valid_lft forever preferred_lft forever

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package systemd - 229-4ubuntu21.29

---------------
systemd (229-4ubuntu21.29) xenial; urgency=medium

  [ Dan Streetman ]
  * d/p/lp1881312/0001-core-don-t-dispatch-load-queue-when-setting-Slice-fo.patch,
    d/p/lp1881312/0002-run-make-slice-work-in-conjunction-with-scope.patch:
    - run new scope unit in specified slice (LP: #1881312)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=b5a778c3cd93e3d684602146f281f315f30778a8
  * d/p/lp1877176-sd-dhcp-client-validate-hostnames-stricter-7308.patch:
    - strictly validate hostname sent to dhcp server (LP: #1877176)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=7a1f1c41dcd860fcba6be42a2153cfe4315ebf17
  * d/e/rules-ubuntu/40-vm-hotadd.rules:
    - Hotadd only offline memory and CPUs
      (LP: #1876018)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=43357bd260a1c3e7b4951d33cbacaebda1d086b3
  * d/p/lp1698388-journal-remote-Ensure-reallocation-of-source-buf-doe.patch:
    - Fix assertion failure when journald source->filled < source->size
      (LP: #1698388)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=d1cc15b88113510227e5a76654e103ef54a8b8f3

  [ Heitor Alves de Siqueira ]
  * d/p/lp1876600-sd-bus-deal-with-cookie-overruns.patch:
    - deal with dbus cookie overruns (LP: #1876600)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=8dc9ef188944349169044d8974a4ffa55c66be9d

 -- Heitor Alves de Siqueira <email address hidden> Tue, 07 Jul 2020 17:28:11 -0400

Changed in systemd (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for systemd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.