Ubuntu
hotkey-setup package

/etc/init.d/hotkey-setup looks at xorg.conf to find what video driver is in use; this doesn't work any more

Bug #221571 reported by Adrian Frith
24
Affects Status Importance Assigned to Milestone
hotkey-setup (Ubuntu)
Fix Released
High
Unassigned
Intrepid
Fix Released
High
Unassigned

Bug Description

Binary package hint: hotkey-setup

In the 'do_video' and 'do_thinkpad' methods in /etc/init.d/hotkey-setup, the following code is used to find out what video driver X is using:

VIDEO=`sed -n -e '/^[ \t]*section[ \\t]*"device"/I,/^[ \t]*endsection/I{/^[ \t]*driver[ \t]*/I{s/^[ \t]*driver[ \t]*"*//I;s/"*[ \t]*$//;p}}' /etc/X11/xorg.conf`

The value of $VIDEO is then tested to see if it is 'intel', 'ati', or 'radeon'. Unfortunately, with the new, less-configuration-required X.Org, the xorg.conf doesn't actually contain a "Driver" line in the "Device" section. The value of $VIDEO ends up being empty, and the code that is conditional on the test doesn't get run when it should.

It doesn't seem like the configuration of the thinkpad_acpi hotkey mask (at line 32 in hotkey-setup) should be dependent on the video driver in use, in any case. Surely if the driver were 'fglrx', for example, the hotkey mask should still be configured?

This is in hardy final, with hotkey-setup version 0.1-17ubuntu21, on an IBM ThinkPad T43 model 2668F5G.

Tags: iso-testing
Revision history for this message
Adrian Frith (adrian-frith) wrote :

I should add: because this affects the setting of the thinkpad_acpi hotkey mask, it has irritating effects like those in bug #220969.

Revision history for this message
bgcommon (bgcommon) wrote :

This bug makes the issue even worse for compaq 6510b/6710b because the value of /proc/acpi/video/*/DOS gets reset to 0 everytime as opposed to 7 which its supposed to be. This causes Bug #157691(Hardy/Gutsy crashes when the lid is closed on a HP 6710b, HP 6510b and HP 2510p) to reappear.

Colin Watson (cjwatson)
Changed in hotkey-setup:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Colin Watson (cjwatson) wrote :

hotkey-setup 0.1-22 tried to address this:

  * Handle systems without xorg.conf files by asking discover v2 about
    the correct X driver to use on a given system, until a way to ask
    X which driver it is using is found.

However, we took discover out of main way back in Ubuntu 5.04 or so, as part of an attempt to reduce the number of different (and therefore occasionally conflicting) hardware detection mechanisms in use, and I don't think we want to reintroduce it. I'm taking this out for now, but I've cranked this bug's importance up and targeted it for Intrepid to ensure that we don't forget about it. Bryce, could you have a look and figure out a better way to do this? Ideally, hotkey-setup wants to be able to ask X which driver it's going to use.

Revision history for this message
Steffen Röcker (sroecker) wrote :

If you keep this fix hotkey-setup should depend on discover. (Just saw an error message while booting my system because I didn't have discover)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hotkey-setup - 0.1-23ubuntu2

---------------
hotkey-setup (0.1-23ubuntu2) intrepid; urgency=low

  * Modify the initscipt to not need discover. (LP: #221571)

 -- Timo Aaltonen <email address hidden> Fri, 08 Aug 2008 16:12:08 +0300

Changed in hotkey-setup:
status: Triaged → Fix Released
Ubuntu QA Website (ubuntuqa)
tags: added: iso-testing
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.