FFe for gnome-main-menu 0.9.11 (universe)

A couple of comments:

1. Was the upstream tarball modified in line with README.Sources? I'm just surprised that your tarball is 825025 bytes while upstream one is 753320 bytes; according to README.Sources the dfsg change was the removal of a po file? Perhaps you have not used the -9 option while recompressing?

2. You mention the removal of symbols, is there an ABI/soname change? I don't see r(b)depends so I'm not overly concerned for the distro, just for any third party apps which might be using libslab (assuming there is any).

3. Finally, can you tell us what testing have you done? I'm just concerned by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=459324 where 0.9.10 was rejected because of the freeze.

1) As noted on the debian/changelog i've fixed the get-orig-source file, so this tarball was repack using it.

812K gnome-main-menu_0.9.10+dfsg.orig.tar.gz
764K gnome-main-menu_0.9.11+dfsg.orig.tar.gz
740K gnome-main-menu-0.9.11.tar.gz

2) Yes, you' re right and this was previous discussed with Sebastien, as upstream didn't bump the SONAME and we don't have any rdepends on this, bumping shlibs should be fine.

3) I understand Debian, but in case of Ubuntu any port to GIO is useful, and i use this version on a daily system.

1) Ah yes, I looked at the wrong dsc. Anyhow, your tarball is 775430 bytes after removing the one file against the original 753320 bytes, so I would still modify the get-orig-source target to compress with maximum compression (no level is specified so it uses the default which is 6).

2, 3) OK, I assume that Sebastien is fine with having this too

motu-release ack from me then.

I'd be careful about SONAME bump, but as far as Sebastien is aware of the issue, it's not a problem. ACK from me, FFe confirmed.

Hi,

I just uploaded this, thanks for your contribution.

Pedro, could you test something for me? Could you
use the new version and click on the network status button
in the bottom right? For me it gives a useless dialog with
"label649" or something as the only text. If you can confirm
can you work out why? I'd be happy to sponsor a patch to
fix it.

Thanks,

James

This bug was fixed in the package gnome-main-menu - 0.9.11+dfsg-0ubuntu1

---------------
gnome-main-menu (0.9.11+dfsg-0ubuntu1) intrepid; urgency=low

  * New upstream release (lp: #273811)
    - Port to GIO (Cosimo Cecchi)
    - Remove Eel dependency (A. Walton)
    - Build against latest NetworkManager (Cosimo Cecchi)
    - Make places use mime type handler (CRivera, Scott Reeves)
    - Support for GSM and CDMA devices (Magnus Boman)
    - Bugfix - Check title for null. BNC#393101 (Scott Reeves)
    - Multiscreen work (Federico Mena Quintero)
    - Remove thumbnailing (Federico Mena Quintero)
    - Escape markup text properly (Denis Washington)
  * debian/control:
    - Remove b-d on libeel2-dev
    - Add b-d on glib 2.16.0, gtk to 2.13.3 and bump up depends
  * debian/patches/20_update_nm_api_usage.patch,
    debian/patches/40_display_menu_on_correct_screen.patch,
    - The change is in the new release
  * debian/rules:
    - Fix get-orig-source
    - Bump shlibs due to removal of some symbols

 -- Pedro Fragoso <email address hidden> Tue, 23 Sep 2008 18:16:44 +0100