Landscape Server

Small smart fixes need to go in the Intrepid package

Bug #279343 reported by Gustavo Niemeyer on 2008-10-06

Affects		Status	Importance	Assigned to	Milestone
	Landscape Server	Fix Released	High	Unassigned	Landscape Server thames
	smart (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

A branch is up for review at

lp:~niemeyer/smart/small-fixes

It integrates a few minor fixes which should be integrated in Smart
and in the Landscape release in Intrepid as soon as possible:

- If deb-non-interactive is set, pass --force-confold to dpkg.
- In the logic for ordering conflicts, use UNPACK to detect for
conflict situations that might require an early removal of a
package that is to be installed later, rather than CONFIG.

It also integrates the following test-fixing changes:

- Fix 404 fetcher error wording so that tests work correctly when
pycurl isn't available and urllib is in use.
- Rename test.py to test so that testing doesn't break in
newer Python releases.

Revision history for this message

Thomas Herve (therve) wrote on 2008-10-07:

Let's go!

[1]
- self.addSuccessor(config, (upgpkg, REMOVE), OPTIONAL)
+ self.addSuccessor(unpack, (upgpkg, REMOVE), OPTIONAL)

This change looks untested :/. I don't know how hard it would be to trigger it. But it looks like the tests don't even go through this path at all

[2] test.py is referenced in several places in the code: MANIFEST.in, usage of the file itself, and in the locale files.

[3] Some flakes
mart/fetcher.py:32: 'string' imported but unused
smart/fetcher.py:1716: 'ftplib' imported but unused
tests/debpm.py:2: 'copy' imported but unused
tests/debpm.py:12: 'REMOVE' imported but unused

[4] Maybe bug #273605 could be solved here?

Thanks!

Andreas Hasenack (ahasenack) on 2008-10-07

Changed in landscape:
status:	New → In Progress

Revision history for this message

Gustavo Niemeyer (niemeyer) wrote on 2008-10-08:

Thanks for the review Thomas!

[1] is fixed with a test, even though it's assertion is disabled because the issue is not yet totally fixed. The branch deb-ordering-fix (which is pretty much ready too) will uncomment the assertion and fix the issue completely.

[2] Fixed!

[3] I won't address these now to reduce the patch on the beta. I'll fix these on deb-ordering-fix.

[4] Good point. That's done!

Andreas Hasenack (ahasenack) on 2008-10-08

Changed in landscape:
milestone:	none → thames

Andreas Hasenack (ahasenack) on 2008-10-09

Changed in landscape:
importance:	Undecided → High
Changed in smart:
status:	New → In Progress

Revision history for this message

Thomas Herve (therve) wrote on 2008-10-09:

I still see 'test.py' in the locale files? But that's minor, +1!

Revision history for this message

Gustavo Niemeyer (niemeyer) wrote on 2008-10-09:

That's been committed in Smart's trunk.

Revision history for this message

Christopher Armstrong (radix) wrote on 2008-10-09:

smart-1.1.1.debdiff Edit (21.2 KiB, text/plain)

Ok, attaching a debdiff for 1.1.1 inclusion in intrepid.

Not sure if this will need an FFE. All the changes are bugfixes in some regard.

Revision history for this message

Christopher Armstrong (radix) wrote on 2008-10-09:

Michael, could I possibly get you to take a look at this patch?

Revision history for this message

Launchpad Janitor (janitor) wrote on 2008-10-10:

This bug was fixed in the package smart - 1.1.1~bzr20081010-0ubuntu0.8.10

---------------
smart (1.1.1~bzr20081010-0ubuntu0.8.10) intrepid; urgency=low

  * New upstream release (LP: #279343).
    - Fixed NameError during smart update (LP: #273605).
    - deb-non-interactive now implies dpkg --force-confold.
    - Fix some dependency resolution problems in some situations.
    - Rename test.py to test so it works in newer Python releases.
    - Make 404 error wording more consistent.

-- Christopher Armstrong <email address hidden> Thu, 09 Oct 2008 16:33:31 -0400