License and Copyright Missing

Bug #322638 reported by Dimitri John Ledkov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The SWORD Project
Fix Released
Undecided
Unassigned
sword (Debian)
Fix Released
Undecided
Unassigned
sword (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

licensecheck reports more than 200 files missing copyright and license information.

$ sudo apt-get install devscripts
$ apt-get source sword
$ cd sword-1.5.9/
$ tar xf sword-1.5.9.tar.gz
$ cd sword-1.5.9/
$ licensecheck -r * | grep UNKNOWN | head
arminst.sh: *No copyright* UNKNOWN
autogen.sh: *No copyright* UNKNOWN
bindings/usrinst.sh: *No copyright* UNKNOWN
bindings/gsoap/gsoapsword.cpp: *No copyright* UNKNOWN
bindings/gsoap/testclient.cpp: *No copyright* UNKNOWN
bindings/swig/examples/mod2zmod.pl: *No copyright* UNKNOWN
bindings/swig/sword.pl: *No copyright* UNKNOWN
bindings/swig/package/autogen.sh: *No copyright* UNKNOWN
bindings/bcppmake/test.cpp: *No copyright* UNKNOWN
bindings/bcppmake/sword.c: *No copyright* UNKNOWN
$ licensecheck -r * | grep UNKNOWN | wc
    238 910 12120

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Upstream bug tracker URL wasn't recognised: http://www.crosswire.org/bugs/browse/API-106

Revision history for this message
Jonathan Marsden (jmarsden) wrote :

I'm not sure this is necessarily a real issue.

licencecheck is great for finding the few added files in a tree that were imported from elsewhere or whatever, but it is not 100% required that every file has its own copyright and licence information in it.

The LICENSE and COPYING files included in the source tarball make the intention of upstream clear: all code files are licenced under the GPLv2.

If there were files from other sources (outside the SWORD project) used that lacked proper licence or copyright we might have an issue, but I don't see anything like that going on.

Looks OK to me, though we could ask upstream to add copyright notices to all files for "next time" :)

Jonathan

Changed in sword:
status: Unknown → Confirmed
Revision history for this message
Jonathan Marsden (jmarsden) wrote :

Most files have had appropriate copyright notices added in the SWORD 1.6.0 release.
SWORD 1.6.0 packages with a much improved and more detailed debian/copyright file are under development using the ~pkgcrosswire team PPA.

Jonathan

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.9 KiB)

This bug was fixed in the package sword - 1.6.0+dfsg-1

---------------
sword (1.6.0+dfsg-1) unstable; urgency=low

  [ Jonathan Marsden ]
  * New upstream release. (Closes: #507960) (LP: #320558)
  * debian/patches/02_libver.diff:
    - Bump SONAME to 8 -- SWORD 1.6 is not backward compatible with 1.5.11.
  * debian/patches/series:
    - Remove 10_diatheke.diff -- included in upstream source.
  * debian/patches/:
    - Remove several old unused .diff files.
    - Add 11_regex_only_when_needed.diff to conditionally include regex lib.
    - Add 12_fix_compiler_warnings.diff to remove all compiler warnings.
    - Add 13_fix_osis2mod_compression_default.diff from upstream svn.
    - Add 14_closing_section_not_chapter.diff from upstream svn.
  * debian/libsword7.*:
    - Rename to libsword8.*
    - Change libsword7 to libsword8 within files.
  * debian/rules:
    - SONAME bump to 8.
    - Set library version check to >= 1.6
  * debian/control:
    - Change libsword7 to libsword8.
    - Add libsword7 to Conflicts.
    - Fix case of sword to SWORD in package descriptions.
    - Bump Standards-Version to 3.8.1 (no changes needed).
    - Fix section for libsword-dbg to avoid lintian warning.
  * debian/rules:
    - Add DFSG get-orig-source target.
  * debian/copyright:
    - Fix various mistakes in initial attempt to document copyrights.

  [ Dmitrijs Ledkovs ]
  * debian/rules: Added utils.mk to use missing-files target and call it on
    each build.
  * debian/libsword-dev.install: Added libsword.la, previously missing.
  * debian/libsword7.install: Added missing libicu translit files.
  * debian/control:
    - Updated all uses of SWORD version to 1.6
    - Added libsword-dbg package
  * debian/watch: Fixed a small mistake which was resulting in extra "."
    in final version name.
  * debian/rules: simplified manpage processing.
  * debian/libsword8.lintian-overrides: added override for module
    installation directory.
  * debian/copyright: Updated with information about everyfile.
    Closes: #513448 LP: #322638
  * debian/diatheke.examples: moved examples here from the diatheke.install
  * debian/rules:
    - enabled shell script based testsuite
    - added commented out cppunit testsuite
  * debian/patches/40_missing_includes.diff:
    - added several missing stdio.h includes to prevent FTBFS of testsuite.

  [ Closed Bugs ]
  * FTBFS on intrepid (LP: #305172)

sword (1.5.11-1) experimental; urgency=low

  [Jonathan Marsden]
  * New upstream release
  * debian/rules:
    - Switch to using more normal CDBS/autotools not tarball in tarball.
    - Build against libicu for better i18n support.
    - Use chrpath on installed binaries to get rid of lintian warnings.
    - Set DEB_DH_MAKESHLIBS_ARGS to (>= 1.5.11) not (>=1.5.11-1).
    - Add pod2man command to generate tei2mod man page.
    - Use -n option on pod2man commands to fix command names in man pages.
  * Bump SONAME to 7.
    - Rename debian/libsword6.* appropriately.
    - Change 6 to 7 in several scripts including debian/rules
      and debian/control
  * debian/patches:
    - Remove most patches as being unnecessary now.
    - Simplify debian/patches/02_libver.diff to only edit t...

Read more...

Changed in sword (Ubuntu):
status: New → Fix Released
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Launchpad couldn't import bug £513448 from debian bug tracker. It's closed now.

Changed in sword (Debian):
importance: Unknown → Undecided
status: Confirmed → New
Changed in sword (Debian):
status: New → Fix Released
Changed in libsword:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.