gajim uses notifications with actions without checking

Bug #328615 reported by David Barth
42
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gajim (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

When a new message arrives while gajim is in the background, a notification appears that, when clicked, brings the relevant window to the front. The action should be made conditional on whether the notification server supports actions.

Related branches

Changed in gajim:
status: New → Confirmed
Revision history for this message
Nafallo Bjälevik (nafallo) wrote :

I'm debating whether this should be in python-notify rather. That would get a bunch of other applications on board for free.

Changed in gajim:
status: Confirmed → Incomplete
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

The reason we fall back to alert boxes at all is that there might be software we don't know about, for which the actions in notifications are vital to the use of the application, and we don't want to render those applications completely unusable in Ubuntu.

I think that argument applies exactly as much to applications using python-notify as it does to applications in general. If so, we should fix applications using python-notify individually, just as we're fixing other applications individually.

Changed in gajim:
status: Incomplete → New
description: updated
Changed in gajim:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
James Westby (james-w) wrote :

Hi,

Here's a patch to fix this one.

Thanks,

James

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gajim - 0.12.1-0ubuntu2

---------------
gajim (0.12.1-0ubuntu2) jaunty; urgency=low

  * Don't use actions in notifications if the server doesn't support them.
    (LP: #328615)

 -- James Westby <email address hidden> Wed, 25 Feb 2009 13:31:57 +0000

Changed in gajim:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.