apport-collect should check the status of tasks

Bug #331839 reported by Brian Murray
4
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

Binary package hint: apport

Release of Ubuntu: 9.04
Package Version: 0.133

The new utility apport-collect doesn't check to see if a bug task is closed before deciding to add the files for the package hook, subsequently unnecessary log files could be added to the bug report. This is also a problem because each attachment didn't end up being a separate comment and Launchpad didn't hide more than 80 comments. I think if the task is closed those files shouldn't be added to the bug report.

Revision history for this message
Brian Murray (brian-murray) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! I fixed the patch, tested it, committed (r1264).

Changed in apport:
assignee: nobody → pitti
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 0.134

---------------
apport (0.134) jaunty; urgency=low

  * debian/local/apport-collect: Do not collect information for closed
    tasks. Thanks for Brian Murray for the initial patch! (LP: #331839)
  * apport/crashdb_impl/launchpad.py, download(): Download
    DpkgTerminalLog.txt attachment as well.
  * apport/report.py: If downloading a nonexisting bug pattern file
    name succeeds and returns a HTML snippet with "404 Not Found",
    consider this as failure. This repairs falling back to source
    package names. (LP: #328751)
  * apport/hookutils.py: Replace tabs with spaces.

 -- Martin Pitt <email address hidden> Fri, 20 Feb 2009 11:22:15 +0100

Changed in apport:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.