qBittorrent

qbittorrent doesn't build with qt 4.5

Bug #332470 reported by leigh123linux on 2009-02-21

Affects		Status	Importance	Assigned to	Milestone
	qBittorrent	Fix Released	High	Christophe Dumez	qBittorrent 1.3.3
	qbittorrent (Ubuntu)	Fix Released	Medium	Unassigned

Bug Description

In file included from /usr/include/QtNetwork/qtcpserver.h:42,
                 from /usr/include/QtNetwork/QTcpServer:1,
                 from httpserver.h:25,
                 from httpserver.cpp:22:
/usr/include/QtNetwork/qhostaddress.h:122: error: expected ',' or '...' before '<' token
/usr/include/QtNetwork/qhostaddress.h:124: error: expected ';' before '<' token

Related branches

lp:ubuntu/lucid/qbittorrent

Revision history for this message

leigh123linux (leigh123linux-deactivatedaccount) wrote on 2009-02-21:

build log Edit (21.6 KiB, text/plain)

Revision history for this message

leigh123linux (leigh123linux-deactivatedaccount) wrote on 2009-02-21:

root log Edit (55.2 KiB, text/plain)

Here the root.log as well

Revision history for this message

Christophe Dumez (hydr0g3n) wrote on 2009-02-21:

Hmm. The error seems to be in Qt. Is that possible? Apparently the compilation problem is caused by QTcpServer include.

Bug is in /usr/include/QtNetwork/qhostaddress.h

Revision history for this message

leigh123linux (leigh123linux-deactivatedaccount) wrote on 2009-02-21:

usr/include/QtNetwork/QTcpServer Edit (24 bytes, text/plain)

Here's usr/include/QtNetwork/QTcpServer from qt 4.5

Revision history for this message

leigh123linux (leigh123linux-deactivatedaccount) wrote on 2009-02-21:

usr/include/QtNetwork/qhostaddress.h Edit (5.0 KiB, text/plain)

And here's usr/include/QtNetwork/qhostaddress.h

>Hmm. The error seems to be in Qt. Is that possible? Apparently the compilation problem is caused by >QTcpServer include.

It is possible that there is a problem with qt as it's a RC

Revision history for this message

leigh123linux (leigh123linux-deactivatedaccount) wrote on 2009-02-21:

Ok I have just filed a bug against qt as it looks like qt is the culprit.

https://bugzilla.redhat.com/show_bug.cgi?id=485677

Revision history for this message

Rex Dieter (rdieter) wrote on 2009-02-22:

workaround undefined QPair Edit (545 bytes, text/plain)

The following patch seems to address the issue of QPair not being properly defined in qhostaddress.h

Revision history for this message

Christophe Dumez (hydr0g3n) wrote on 2009-02-22:

I installed Qt4.5rc1 from Ubuntu Jaunty today. It compiles just fine.

Ubuntu/Debian may have patched it before upload though.

Revision history for this message

Christophe Dumez (hydr0g3n) wrote on 2009-02-22:

I just checked and Ubuntu does not have any patch for qtcpserver.h or qhostaddress.h

Revision history for this message

leigh123linux (leigh123linux-deactivatedaccount) wrote on 2009-02-23:

#10

qhostaddress.h qpair-related issue Edit (213 bytes, text/plain)

Thanks for taking the time to help, I have added this patch to enable qbittorrent to build.

Revision history for this message

Andrew Starr-Bochicchio (andrewsomething) wrote on 2009-03-06:

#11

http://launchpadlibrarian.net/23561101/buildlog_ubuntu-jaunty-i386.qbittorrent_1.3.1-1~ppa2_FAILEDTOBUILD.txt.gz

Changed in qbittorrent:
importance:	Undecided → Medium
status:	New → Triaged

Revision history for this message

Christophe Dumez (hydr0g3n) wrote on 2009-03-06:

#12

I'm on it.

Changed in qbittorrent:
assignee:	nobody → hydr0g3n
importance:	Undecided → High
status:	New → In Progress

Revision history for this message

Christophe Dumez (hydr0g3n) wrote on 2009-03-06:

#13

Qt4.5 compilation fix Edit (300 bytes, text/plain)

Here is the patch. I applied it to svn v1_3_x stable branch as well as trunk. Thank you for the report.

Revision history for this message

Andrew Starr-Bochicchio (andrewsomething) wrote on 2009-03-06:

#14

There's a fix for the ubuntu package in Bug 335741 as it is going to need a rebuild due to the pending libtorrent-rasterbar SONAME bump:

http://launchpadlibrarian.net/23563140/qbittorrent_1.3.1-1ubuntu1.debdiff

Changed in qbittorrent:
assignee:	nobody → andrewsomething
status:	Triaged → In Progress

Christophe Dumez (hydr0g3n) on 2009-03-06

Changed in qbittorrent:
status:	In Progress → Fix Committed

Revision history for this message

Christophe Dumez (hydr0g3n) wrote on 2009-03-06:

#15

I will release v1.3.2 soon. I'm fixing other bugs which were reported since v1.3.1 too.

Changed in qbittorrent:
milestone:	none → 1.3.2

Revision history for this message

Christophe Dumez (hydr0g3n) wrote on 2009-03-07:

#16

qBittorrent v1.3.2 was just released.

Changed in qbittorrent:
status:	Fix Committed → Fix Released

Andrew Starr-Bochicchio (andrewsomething) on 2009-03-07

Changed in qbittorrent:
assignee:	andrewsomething → nobody
status:	In Progress → Confirmed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2009-03-11:

#17

This bug was fixed in the package qbittorrent - 1.3.1-1ubuntu1

---------------
qbittorrent (1.3.1-1ubuntu1) jaunty; urgency=low

  * Rebuild for libtorrent-rasterbar SONAME bump.
  * Fix FTBFS with QT 4.5 (LP: #332470)
   - debian/control, debian/rules: Add quilt magic.
   - Add debian/patches/10_ftbfs_httpserver_include.patch

-- Andrew Starr-Bochicchio <email address hidden> Fri, 06 Mar 2009 16:48:47 -0500