Buddy list should raise when trying to launch pidgin a second time

Bug #354298 reported by Ken VanDine
12
Affects Status Importance Assigned to Milestone
pidgin (Ubuntu)
Fix Released
High
Ken VanDine

Bug Description

Binary package hint: pidgin

Now that we rely on the indicator applet as a mechanism to access the buddy list, it might be hard for some users to find their buddy list until they get familiar with the indicator.

Currently, if you run pidgin from the command line or launch it from the menu it checks to see if there is a pidgin instance running and exits if there is. Pidgin should actually raise the existing buddy list window if it is already running.

Related branches

Revision history for this message
Ken VanDine (ken-vandine) wrote :

This patch adds a script to check if pidgin is already running, and if so raise the buddy list window instead of exiting. Any arguments passed will cause the script to skip the check and just pass them on to pidgin.real

Changed in pidgin (Ubuntu):
assignee: nobody → ken-vandine
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

I wonder if this wouldn't be easier to fix directly in the pidgin code, instead of introducing a wrapper script? This could then even go upstream.

If that is too hard, the approach certainly works. However, using pidof is wrong here, since that will also catch pidgin instances from other users, and thus only one user could run pidgin at a time. If you need to pursue the shell approach, I recommend using pgrep or ps u. You also need to add a procps dependency to the package.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Ah, OK good point. I think the ideal solution is use libunique, which is what i think we should do eventual and get it upstream. But the overhead for implementing that for jaunty is just to high. Ted and I discussed that a little already. I will alter it to not rely on pidof.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Updated debdiff to use pgrep, should be good to go now.

Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

This is a critical usability issue. Should be fixed if at all possible.

Changed in pidgin (Ubuntu):
importance: Undecided → High
Revision history for this message
Sebastien Bacher (seb128) wrote :

could you also open a bug upstream to suggest the change there? they might have constructive comments, I would be in favor of having the pidgin code doing the focus change rather than a wrapper

Revision history for this message
Ken VanDine (ken-vandine) wrote :
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Updated debdiff apply patch from upstream which fixes a bug that prevented this behavior

Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for opening that upstream the new version is much nicer, will sponsor the update now

Changed in pidgin (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pidgin - 1:2.5.5-1ubuntu6

---------------
pidgin (1:2.5.5-1ubuntu6) jaunty; urgency=low

  * debian/patches/62_dbus_fix.patch:
    - The buddy list should be raised when launching a second time, this patch
      from darkrain42 fixes a bug that prevented that behavior (LP: #354298)

 -- Ken VanDine <email address hidden> Wed, 08 Apr 2009 14:00:07 -0400

Changed in pidgin (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.