configure-x.sh fails to set HorizSync and VertRefresh with sis driver

Bug #412034 reported by Veli-Matti Lintu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ltsp (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

This affects thin clients using sis x.org driver and X_HORZSYNC and X_VERTREFRESH set in lts.conf. The problem was found on Hardy, but the script in question seems to be unchanged in Karmic.

When booting an ltsp client with X_HORZSYNC and X_VERTREFRESH set in lts.conf, the configure-x.sh script fails to add the HorizSync and VertRefresh options in the created xorg.conf as the sis driver adds similarly named options in the file.

The relevant options set in lts.conf are:
        X_HORZSYNC = 30-82
        X_VERTREFRESH = 56-76

When configure-x.sh runs "Xorg -configure", it creates xorg.conf.new that has section like this:

Section "Device"
        ...
        #Option "SecondMonitorHorizSync" # <str>
        #Option "SecondMonitorVertRefresh" # <str>
        ...
        Identifier "Card0"
        Driver "sis"
        VendorName "Silicon Integrated Systems [SiS]"
        BoardName "661/741/760 PCI/AGP or 662/761Gx PCIE VGA Display Adapter"
        BusID "PCI:1:0:0"
EndSection

In configure-x.sh the existence of the HorizSync and VertRefresh settings are checked like this:

if [ -z "$(grep HorizSync $INPUT_FILE)"] && [ -z "$(grep VertRefresh $INPUT_FILE)"];then

This matched HorizSync to SecondMonitorHorizSync and VertRefresh to SecondMonitorVertRefresh which in turn calls the wrong sed command. As a result the parameters are not added to /etc/X11/xorg.conf as they should.

The expected result in xorg.conf would be:

Section "Monitor"
VertRefresh 56-76
HorizSync 30-82
        Identifier "Monitor0"
        VendorName "Monitor Vendor"
        ModelName "Monitor Model"
EndSection

Instead it results in this:

Section "Monitor"
        Identifier "Monitor0"
        VendorName "Monitor Vendor"
        ModelName "Monitor Model"
EndSection

xorg.conf created by configure-x.sh attached

Related branches

Revision history for this message
Veli-Matti Lintu (vmlintu) wrote :
Revision history for this message
Juha Erkkilä (juha-erkkila) wrote :

The attached patch likely fixes the problem.

Revision history for this message
Oliver Grawert (ogra) wrote :

even though configure-x.sh isnt used since ages anymore, i committed the fix in the upstream branch in case someone wants to make use of the script (before we actually remove it from the code tree)

Changed in ltsp (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ltsp - 5.1.85-0ubuntu1

---------------
ltsp (5.1.85-0ubuntu1) karmic; urgency=low

  * Bump standards to 3.8.3
  * Update maintainer
  * Add cron to ltsp-client-core depends to make auto-shutdown work
  * Add sane-utils to ltsp-client depends to make scanner work
  * Add Vcs-Bzr and Vcs-Browser to source package

  * Add a few forgotten upstream manpages
  * Drop udhcp scripts from packaging (pushed upstream)
  * Use the geode driver for Geode GX2 in karmic
  * Make the bug reporting script executable

  * New upstream bugfix release (5.1.85)
   * Fix typo and update translations
   * Mark init scripts executable
   * Make scanners work again
   * Fix detection of pulseaudio 0.9.16
   * Fix configure-x.sh (LP: #412034)
   * Update LSB headers for ltsp-core (drop hal)

 -- Stephane Graber <email address hidden> Sun, 06 Sep 2009 22:05:57 -0400

Changed in ltsp (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.